v1.4.0

- Fixed notification listener and updated metadata
shub39 · Jul 20, 2024 · 67717a5 · 67717a5
1 parent 2f479e1
commit 67717a5
Show file tree

Hide file tree

Showing 15 changed files with 20 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -29,6 +29,7 @@
 - [x] Share Lyrics
 - [x] Customisations
 - [x] Auto-fill current playing song in search
+- [ ] Synced Lyrics
 
 ## Why ❔
 Spotify removed its feature to see and share lyrics from its free tier. So I made this app to get and store lyrics for my favorite songs from Genius and share them like Spotify, all in Material 3 look.

diff --git a/app/build.gradle.kts b/app/build.gradle.kts
@@ -14,8 +14,8 @@ android {
         applicationId = "com.shub39.rush"
         minSdk = 29
         targetSdk = 35
-        versionCode = 8
-        versionName = "1.3.0"
+        versionCode = 9
+        versionName = "1.4.0"
 
         testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
         vectorDrawables {

diff --git a/app/release/app-release.apk b/app/release/app-release.apk
diff --git a/app/release/baselineProfiles/0/app-release.dm b/app/release/baselineProfiles/0/app-release.dm
diff --git a/app/release/baselineProfiles/1/app-release.dm b/app/release/baselineProfiles/1/app-release.dm
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -34,8 +34,10 @@
         </provider>
         <service android:name=".listener.NotificationListener"
             android:permission="android.permission.BIND_NOTIFICATION_LISTENER_SERVICE"
+            android:enabled="true"
             android:exported="true"
-            android:foregroundServiceType="mediaProcessing">
+            android:process=":NLS"
+            android:label="@string/notification">
             <intent-filter>
                 <action android:name="android.service.notification.NotificationListenerService" />
             </intent-filter>

diff --git a/app/src/main/java/com/shub39/rush/page/LyricsPage.kt b/app/src/main/java/com/shub39/rush/page/LyricsPage.kt
@@ -47,6 +47,7 @@ import com.shub39.rush.component.ArtFromUrl
 import com.shub39.rush.component.Empty
 import com.shub39.rush.database.SettingsDataStore
 import com.shub39.rush.listener.NotificationListener
+import com.shub39.rush.ui.theme.Typography
 import com.shub39.rush.viewmodel.RushViewModel
 import kotlinx.coroutines.launch
 
@@ -117,11 +118,15 @@ fun LyricsPage(
             } else if (nonNullSong.geniusLyrics != null) {
                 source = "Genius"
             }
-//            if (nonNullSong.syncedLyrics != null && NotificationListener.canAccessNotifications(
-//                    context
-//                )
-//            ) {
+
+//            if (nonNullSong.syncedLyrics != null) {
 //                syncedLyrics = true
+//            }
+//
+//            if (syncedLyrics && (rushViewModel.currentPlayingSongInfo.value?.first
+//                    ?: "") == nonNullSong.title
+//            ) {
+//                syncLyrics = true
 //            }
         }
 
@@ -170,9 +175,9 @@ fun LyricsPage(
                     }
                     Row {
 //                        val iconColor = if (syncLyrics) {
-//                            IconButtonDefaults.iconButtonColors()
-//                        } else {
 //                            IconButtonDefaults.filledIconButtonColors()
+//                        } else {
+//                            IconButtonDefaults.iconButtonColors()
 //                        }
 //
 //                        if (syncedLyrics) {
@@ -283,7 +288,8 @@ fun LyricsPage(
                         Text(
                             text = "From $source",
                             modifier = Modifier.fillMaxWidth(),
-                            textAlign = TextAlign.Center
+                            textAlign = TextAlign.Center,
+                            style = Typography.bodySmall
                         )
                     }
                 }

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -10,6 +10,7 @@
     <string name="suggestion">Maybe search for something?</string>
     <string name="downloaded">Saved lyrics</string>
     <string name="delete_all">Delete all lyrics</string>
+    <string name="notification">Notification Listener Service</string>
     <string name="unknown_album">Unknown album</string>
     <string name="width">Width</string>
     <string name="colors">Colors</string>

diff --git a/fastlane/metadata/android/en-US/images/phoneScreenshots/1.png b/fastlane/metadata/android/en-US/images/phoneScreenshots/1.png
diff --git a/fastlane/metadata/android/en-US/images/phoneScreenshots/2.png b/fastlane/metadata/android/en-US/images/phoneScreenshots/2.png
diff --git a/fastlane/metadata/android/en-US/images/phoneScreenshots/3.png b/fastlane/metadata/android/en-US/images/phoneScreenshots/3.png
diff --git a/fastlane/metadata/android/en-US/images/phoneScreenshots/5.png b/fastlane/metadata/android/en-US/images/phoneScreenshots/5.png
diff --git a/fastlane/metadata/android/en-US/images/phoneScreenshots/6.png b/fastlane/metadata/android/en-US/images/phoneScreenshots/6.png
diff --git a/fastlane/metadata/android/en-US/images/phoneScreenshots/7.png b/fastlane/metadata/android/en-US/images/phoneScreenshots/7.png
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -9,7 +9,6 @@ fuelCoroutines = "2.3.1"
 gson = "2.10.1"
 jsoup = "1.16.2"
 koinAndroid = "3.4.3"
-koinAndroidxCompose = "3.6.0"
 koinAndroidxComposeVersion = "3.4.3"
 kotlin = "2.0.0"
 coreKtx = "1.13.1"