🎨 Decreased padding and UI improvements

shub39 · Nov 11, 2024 · 8b501fe · 8b501fe
1 parent cbc7ad9
commit 8b501fe
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 6 deletions.
diff --git a/app/src/main/java/com/shub39/rush/ui/page/component/ArtFromUrl.kt b/app/src/main/java/com/shub39/rush/ui/page/component/ArtFromUrl.kt
@@ -5,6 +5,7 @@ import androidx.compose.material3.MaterialTheme
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.layout.ContentScale
 import androidx.compose.ui.res.painterResource
 import coil.ImageLoader
@@ -20,6 +21,8 @@ import org.koin.compose.koinInject
 fun ArtFromUrl(
     imageUrl: String?,
     modifier: Modifier = Modifier,
+    baseColor: Color = MaterialTheme.colorScheme.surface,
+    highlightColor: Color = MaterialTheme.colorScheme.primary,
     imageLoader: ImageLoader = koinInject()
 ) {
     CoilImage(
@@ -29,8 +32,8 @@ fun ArtFromUrl(
         component = rememberImageComponent {
             +ShimmerPlugin(
                 Shimmer.Resonate(
-                    baseColor = MaterialTheme.colorScheme.surface,
-                    highlightColor = MaterialTheme.colorScheme.primary
+                    baseColor = baseColor,
+                    highlightColor = highlightColor
                 )
             )
         },

diff --git a/app/src/main/java/com/shub39/rush/ui/page/lyrics/LyricsPage.kt b/app/src/main/java/com/shub39/rush/ui/page/lyrics/LyricsPage.kt
@@ -229,6 +229,8 @@ fun LyricsPage(
                     AnimatedVisibility(top > 2) {
                         ArtFromUrl(
                             imageUrl = song.artUrl,
+                            highlightColor = cardContent,
+                            baseColor = cardBackground,
                             modifier = Modifier
                                 .height(150.dp)
                                 .fillMaxWidth(),
@@ -262,6 +264,8 @@ fun LyricsPage(
                         ) {
                             ArtFromUrl(
                                 imageUrl = song.artUrl,
+                                highlightColor = cardContent,
+                                baseColor = cardBackground,
                                 modifier = Modifier
                                     .clip(MaterialTheme.shapes.small)
                                     .size(150.dp)

diff --git a/app/src/main/java/com/shub39/rush/ui/page/share/component/RushedShareCard.kt b/app/src/main/java/com/shub39/rush/ui/page/share/component/RushedShareCard.kt
@@ -85,7 +85,8 @@ fun RushedShareCard(
 
             Column(
                 modifier = Modifier
-                    .padding(46.dp)
+                    .fillMaxWidth()
+                    .padding(28.dp)
                     .align(Alignment.Center)
             ) {
                 LazyColumn(

diff --git a/app/src/main/java/com/shub39/rush/ui/page/share/component/SpotifyShareCard.kt b/app/src/main/java/com/shub39/rush/ui/page/share/component/SpotifyShareCard.kt
@@ -7,6 +7,7 @@ import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.Row
 import androidx.compose.foundation.layout.Spacer
 import androidx.compose.foundation.layout.fillMaxSize
+import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.lazy.LazyColumn
@@ -63,7 +64,9 @@ fun SpotifyShareCard(
                     contentAlignment = Alignment.Center
                 ) {
                     Card(
-                        modifier = Modifier.padding(32.dp),
+                        modifier = Modifier
+                            .fillMaxWidth()
+                            .padding(28.dp),
                         onClick = { variant = !variant },
                         colors = CardDefaults.cardColors(
                             contentColor = innerContentColor,
@@ -134,7 +137,7 @@ fun SpotifyShareCard(
                 Column (
                     modifier = Modifier
                         .fillMaxSize()
-                        .padding(46.dp),
+                        .padding(32.dp),
                     verticalArrangement = Arrangement.Center
                 ) {
                     Row(

diff --git a/app/src/main/java/com/shub39/rush/viewmodel/RushViewModel.kt b/app/src/main/java/com/shub39/rush/viewmodel/RushViewModel.kt
@@ -316,7 +316,7 @@ class RushViewModel(
         query: String,
         fetch: Boolean = _lyricsState.value.autoChange,
     ) {
-        if (query.isEmpty() || _lyricsState.value.searching.first) return
+        if (query.isEmpty() || _lyricsState.value.searching.first || query == _lastSearched.value) return
 
         viewModelScope.launch {
             _lyricsState.update {