Fix MacOS write error caused by unflushed buffer #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2021
|
I can confirm this helps and works on macOS 11.1 |
LumitoLuma
added a commit
to LumitoLuma/BOSSA
that referenced
this pull request
Jun 25, 2021
|
It also improves operations' speed in my Debian Testing |
|
Any news on merging this? @kaysievers just a nitpick you could add a commit summary describing the issues of failed flashing attempts. |
lynxis
added a commit
to lynxis/packages
that referenced
this pull request
Nov 8, 2021
bossa only waited 1ms for the serial device instead calling tcdrain(). Without this patch bossa is failing to flash a ATSAM3S4 8/10 times. Patch has been submitted as PR#150 upstream. shumatech/BOSSA#150 Signed-off-by: Alexander Couzens <[email protected]>
lynxis
added a commit
to lynxis/packages
that referenced
this pull request
Nov 9, 2021
bossa only waited 1ms for the serial device instead calling tcdrain(). Without this patch bossa is failing to flash a ATSAM3S4 8/10 times. Patch has been submitted as PR#150 upstream. shumatech/BOSSA#150 Signed-off-by: Alexander Couzens <[email protected]>
PolynomialDivision
pushed a commit
to openwrt/packages
that referenced
this pull request
Nov 9, 2021
bossa only waited 1ms for the serial device instead calling tcdrain(). Without this patch bossa is failing to flash a ATSAM3S4 8/10 times. Patch has been submitted as PR#150 upstream. shumatech/BOSSA#150 Signed-off-by: Alexander Couzens <[email protected]>
1715173329
pushed a commit
to immortalwrt/packages
that referenced
this pull request
Nov 9, 2021
bossa only waited 1ms for the serial device instead calling tcdrain(). Without this patch bossa is failing to flash a ATSAM3S4 8/10 times. Patch has been submitted as PR#150 upstream. shumatech/BOSSA#150 Signed-off-by: Alexander Couzens <[email protected]> Signed-off-by: Tianling Shen <[email protected]>
utoni
pushed a commit
to utoni/openwrt-packages
that referenced
this pull request
Jan 21, 2022
bossa only waited 1ms for the serial device instead calling tcdrain(). Without this patch bossa is failing to flash a ATSAM3S4 8/10 times. Patch has been submitted as PR#150 upstream. shumatech/BOSSA#150 Signed-off-by: Alexander Couzens <[email protected]>
graysky2
pushed a commit
to graysky2/packages
that referenced
this pull request
Feb 3, 2022
bossa only waited 1ms for the serial device instead calling tcdrain(). Without this patch bossa is failing to flash a ATSAM3S4 8/10 times. Patch has been submitted as PR#150 upstream. shumatech/BOSSA#150 Signed-off-by: Alexander Couzens <[email protected]>
|
I could confirm that there is macos upload issue with bossac 1.9.1 . We have user report that we have to roll back to bossac 1.8 https://forums.adafruit.com/viewtopic.php?f=19&t=187831 |
graysky2
pushed a commit
to graysky2/packages
that referenced
this pull request
Feb 6, 2022
bossa only waited 1ms for the serial device instead calling tcdrain(). Without this patch bossa is failing to flash a ATSAM3S4 8/10 times. Patch has been submitted as PR#150 upstream. shumatech/BOSSA#150 Signed-off-by: Alexander Couzens <[email protected]>
utoni
pushed a commit
to utoni/openwrt-packages
that referenced
this pull request
May 30, 2022
bossa only waited 1ms for the serial device instead calling tcdrain(). Without this patch bossa is failing to flash a ATSAM3S4 8/10 times. Patch has been submitted as PR#150 upstream. shumatech/BOSSA#150 Signed-off-by: Alexander Couzens <[email protected]>
1582130940
pushed a commit
to 1582130940/OpenWrt-Lean-Packages
that referenced
this pull request
Jan 20, 2023
bossa only waited 1ms for the serial device instead calling tcdrain(). Without this patch bossa is failing to flash a ATSAM3S4 8/10 times. Patch has been submitted as PR#150 upstream. shumatech/BOSSA#150 Signed-off-by: Alexander Couzens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the current sleep() with the operating system's flush() call to write out the buffer.