Improved UI in LookupConditions #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BH4HPA
approved these changes
Oct 29, 2023
|
@hidacow Please review your changes at https://pre.xk.shuosc.com/ which was deployed. Once confirmed, I'll deploy it on the main domain. |
|
It looks good! Deploy it to production please. |
|
@hidacow Great! 🎉 Thank you for confirming. I have now completed the deployment. If you encounter any issues or have further feedback, please do not hesitate to let me know. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
majorand changes thecollege, the selectedmajorwill not change even it does not exist in the newly selectedcollege. This has been resolved by binding a function to resetmajorto default, which is全部, whencollegechanges.a-selectto make it easier to filter through a long list of colleges, majors and properties.