A bunch of fixes and improvements #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hard-coded paths below /tmp/ are a security issue on shared hosts. /tmp/ is (often) cleaned up on reboot.
Fix spelling errors. Fix broken links, e.g. https:// everywhere. Fix Sphinx reST markup.
pyupgrade --py38-plus ruff check --fix setup.py vncdotool/*.py
move mouse diagonally instead of first going up/down and then left/right. Do not use `time.sleep()` with Twisted reactor as it will also pause all other event processing. Patch `vncev` to print all mouse events, including those where not button is pressed / released. Issue sibson#287
|
Thank you for the attentiveness and thoroughness as always. I delayed looking at this for a while because it seemed so large, but it looks like the semantic changes are minimal. |
pmhahn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mouseDragusingsleep()and depending on SelectReactor internal knowledge. 'SelectReactor' object has no attribute 'doPoll' #287 1.10 use mouseDrag not work，err is AttributeError: 'SelectReactor' object has no attribute 'doPoll' #260As always more testing (from you) is appreciated 😉