Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip #118

Merged
merged 3 commits into from
Feb 5, 2025
Merged

wip #118

merged 3 commits into from
Feb 5, 2025

Conversation

HinsonSIDAN
Copy link
Member

Thank you for contributing to Whisky! We appreciate your effort and dedication to improving this project. To ensure that your contribution is in line with the project's guidelines and can be reviewed efficiently, please fill out the template below.

Remember to follow our Contributing Guide before submitting your pull request.

Summary

Please provide a brief, concise summary of the changes in your pull request. Explain the problem you are trying to solve and the solution you have implemented.

Type of Change

Please mark the relevant option(s) for your pull request:

Feature Change

Type of feature change:

  1. New feature - non-breaking change which adds functionality
  2. Breaking change - fix or feature that would cause existing functionality to not work as expected
  • Rust crate whisky - New feature
  • Rust crate whisky - Breaking change
  • WASM sidan-csl-rs - New feature
  • WASM sidan-csl-rs - Breaking change

Maintenance

  • Bug fix (non-breaking change which fixes an issue)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Checklist

Please ensure that your pull request meets the following criteria:

  • My code is appropriately commented and includes relevant documentation, if necessary
  • I have added tests to cover my changes, if necessary
  • I have updated the documentation, if necessary
  • All new and existing tests pass
  • Both rust and wasm build pass

Additional Information

If you have any additional information or context to provide, such as screenshots, relevant issues, or other details, please include them here.

@HinsonSIDAN HinsonSIDAN requested a review from twwu123 February 5, 2025 14:36
Copy link
Collaborator

@twwu123 twwu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twwu123 twwu123 merged commit 9c2dbb3 into master Feb 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants