Refactor code to remove version from the PySiddhi name #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grainier Can you please help with reviewing this? |
grainier
reviewed
Jun 19, 2019
| @@ -4,8 +4,8 @@ | |||
| described via a ***Streaming SQL language***, and triggers actions. It performs both ***Stream Processing*** and | |||
| ***Complex Event Processing*** on streaming data. Its Siddhi core is written in Java library. | |||
|
|
|||
| - PySiddhi4 wraps [Siddhi 4](https://wso2.github.io/siddhi/) | |||
| - PySiddhi4 includes a REST Client for [WSO2 Stream Processor(SP) 4.x.x](https://wso2.com/analytics). | |||
| - PySiddhi wraps [Siddhi 4](https://wso2.github.io/siddhi/) | |||
There was a problem hiding this comment.
Are we wrapping Siddhi 4 or 5?
grainier
reviewed
Jun 19, 2019
| name="PySiddhi4", | ||
| version="1.1.0", | ||
| name="PySiddhi", | ||
| version="4.0.0", |
There was a problem hiding this comment.
If we are changing the name, why version from "4.0.0"?
grainier
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR renames PySiddhi4 to PySiddhi by removing the version from the component name.
Security checks