Refactor the code in order to work with latest siddhi released version and few improvements #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for basic auth in event simulation api's and siddhi app management client api. Adding support for load libraries from user defined path(Siddhi-sdk).
sajithshn
approved these changes
Apr 12, 2018
ksdperera
reviewed
Oct 18, 2018
| @@ -1,4 +1,22 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| ~ Copyright (c) 2017, WSO2 Inc. (http://www.wso2.org) All Rights Reserved. | |||
There was a problem hiding this comment.
Incorrect licenses year, it should be 2018
There was a problem hiding this comment.
This file was added on 2017. That's why I added 2017 as the license year
ksdperera
reviewed
Oct 18, 2018
| @@ -1,18 +1,41 @@ | |||
| # --------------------------------------------------------------------------- | |||
| # Copyright (c) 2017, WSO2 Inc. (http://www.wso2.org) All Rights Reserved. | |||
There was a problem hiding this comment.
Please fix the License header year in all the places
There was a problem hiding this comment.
This file was added in 2017. That's why I added 2017 as the license year
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
By this,