-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement state storage #58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d22fdd
to
723183d
Compare
Consider removing
from |
Good one, thank you! |
967beab
to
cff2ae6
Compare
Unix4ever
reviewed
May 13, 2024
cff2ae6
to
e62473c
Compare
smira
reviewed
May 13, 2024
4380f91
to
6dfd1d5
Compare
smira
reviewed
May 17, 2024
c2afe4d
to
8e73eb9
Compare
smira
reviewed
May 21, 2024
smira
reviewed
May 21, 2024
8e73eb9
to
a72fe44
Compare
smira
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆒 🚀
On a best-effort basis, store the state on the disk periodically and on shutdown & restore it from the disk on startup. Additionally, bump Go version, deps & rekres. Closes siderolabs#54. Signed-off-by: Utku Ozdemir <[email protected]>
a72fe44
to
ea8b8f1
Compare
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a best-effort basis, store the state on the disk periodically and on shutdown & restore it from the disk on startup.
Additionally, bump Go version, deps & rekres.
Closes #54.