Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement state storage #58

Merged
merged 1 commit into from
May 22, 2024

Conversation

utkuozdemir
Copy link
Member

@utkuozdemir utkuozdemir commented May 10, 2024

On a best-effort basis, store the state on the disk periodically and on shutdown & restore it from the disk on startup.

Additionally, bump Go version, deps & rekres.

Closes #54.

@utkuozdemir utkuozdemir force-pushed the state-storage branch 2 times, most recently from 6d22fdd to 723183d Compare May 10, 2024 18:20
@nberlee
Copy link

nberlee commented May 10, 2024

Consider removing

Moreover, the discovery service has no peristence. Data is stored in memory only [...]

from internal/landing/html/index.html

@utkuozdemir
Copy link
Member Author

Consider removing

Moreover, the discovery service has no peristence. Data is stored in memory only [...]

from internal/landing/html/index.html

Good one, thank you!

@utkuozdemir utkuozdemir force-pushed the state-storage branch 3 times, most recently from 967beab to cff2ae6 Compare May 10, 2024 21:49
Dockerfile Outdated Show resolved Hide resolved
internal/state/snapshot.go Outdated Show resolved Hide resolved
internal/state/snapshot.go Outdated Show resolved Hide resolved
@utkuozdemir utkuozdemir force-pushed the state-storage branch 4 times, most recently from 4380f91 to 6dfd1d5 Compare May 16, 2024 09:18
api/storage/storage.proto Show resolved Hide resolved
api/storage/storage.proto Outdated Show resolved Hide resolved
cmd/snapshot-decoder/main.go Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
internal/landing/html/index.html Show resolved Hide resolved
internal/state/snapshot.go Show resolved Hide resolved
internal/state/storage/protobuf.go Outdated Show resolved Hide resolved
internal/state/storage/storage.go Outdated Show resolved Hide resolved
internal/state/storage/storage.go Outdated Show resolved Hide resolved
@utkuozdemir utkuozdemir force-pushed the state-storage branch 4 times, most recently from c2afe4d to 8e73eb9 Compare May 21, 2024 10:08
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒 🚀

internal/state/storage/storage.go Show resolved Hide resolved
On a best-effort basis, store the state on the disk periodically and on shutdown & restore it from the disk on startup.

Additionally, bump Go version, deps & rekres.

Closes siderolabs#54.

Signed-off-by: Utku Ozdemir <[email protected]>
@utkuozdemir
Copy link
Member Author

/m

@talos-bot talos-bot merged commit ea8b8f1 into siderolabs:main May 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide some state persistence over restarts
6 participants