-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cloudflared system extension #542
Conversation
6f79c1c
to
04d2825
Compare
Cloudflare Tunnel securely connects resources to Cloudflare without a public IP. Signed-off-by: Maxime NARBAUD <[email protected]> Signed-off-by: Noel Georgi <[email protected]>
04d2825
to
1dd6c36
Compare
/m |
Hi @frezbo, I've just seen your commit, and instead of retrieving the cloudflared binaries directly, you locate the sources and build the binary. However, cloudflared is built with a version of go ‘modified’ by Cloudflare (https://github.com/cloudflare/go), see the Dockerfile: https://github.com/cloudflare/cloudflared/blob/master/Dockerfile I can push a new PR by building the binary from source with Cloudflare's go executable. What do you think about? |
We usually do that, so we build all binaries with the go version that ships with our toolchain, we pick a different one only for special cases
Are you sure https://github.com/cloudflare/cloudflared/blob/master/Dockerfile#L4 this just seems to use upstream golang image |
nevermind, saw the lines after that, in that case I guess we can fallback to pre-built binaries, wdyt @smira |
idk, mixed feelings about that. but I guess if someone runs |
Hi, so finally ? |
yes, we would use the binaries |
Okay, I'll push a fix then |
This PR adds a new system extension cloudflared
Cloudflare Tunnel securely connects resources to Cloudflare without a public IP. A lightweight daemon (cloudflared) creates outbound-only connections to Cloudflare, allowing safe access to services like HTTP, SSH, remote desktops, and other protocols.
More info: https://github.com/cloudflare/cloudflared/