feat: rework iscsi-tools #577
Open
+16
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `tgtd` is only needed if exposing `iSCSI` targets from the host, not needed when using as a client. * Use `/system/etc` as writable homedir for open-iscsi * Drop `isns` since we never ran `isns` daemon We could also split the `iscsid-wrapper` into two services, will do after what comes out of siderolabs/talos#10009. Signed-off-by: Noel Georgi <[email protected]>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Jan 5, 2025
Rework `iscsi-tools` extensions tested based on siderolabs/extensions#577 Signed-off-by: Noel Georgi <[email protected]>
smira
reviewed
Jan 8, 2025
| @@ -23,18 +23,19 @@ func main() { | |||
|
|
|||
| cmd.Stdout = &cmdOut | |||
|
|
|||
| if _, err := os.Stat("/etc/iscsi/initiatorname.iscsi"); err != nil { | |||
There was a problem hiding this comment.
how would this work on upgrades? if there already was a name provided?
|
Please test this with longhorn... |
already here siderolabs/talos#10087 |
|
And Synology CSI, which frankly needs docs revisions. I have a Synology NAS I can use to help test, if necessary. |
this is not something we can test here, so if possible that would be great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tgtdis only needed if exposingiSCSItargets from the host, not needed when using as a client./system/etcas writable homedir for open-iscsiisnssince we never ranisnsdaemonWe could also split the
iscsid-wrapperinto two services, will do after what comes out ofsiderolabs/talos#10009.