Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support generating iqn and nqn during install #10009

Open
Tracked by #9899
frezbo opened this issue Dec 20, 2024 · 2 comments · May be fixed by #10162
Open
Tracked by #9899

Support generating iqn and nqn during install #10009

frezbo opened this issue Dec 20, 2024 · 2 comments · May be fixed by #10162

Comments

@frezbo
Copy link
Member

frezbo commented Dec 20, 2024 •
edited
Loading

Feature Request

Currently we generate an iqn once when the iscsi extension is installed, since iqn and nqn are pretty standard, move this to talos install process, so that they remain during the lifecycle of the node.

Ref: https://docs.netapp.com/us-en/e-series-santricity/sm-settings/nvme-overview.html
@frezbo frezbo mentioned this issue Jan 2, 2025
Open
@frezbo
Copy link
Member Author

frezbo commented Jan 2, 2025

nvme gen-hostnqn can be used

frezbo added a commit to frezbo/extensions that referenced this issue Jan 5, 2025
@frezbo
feat: rework iscsi-tools
8933bea 
* `tgtd` is only needed if exposing `iSCSI` targets from the host, not
needed when using as a client.
* Use `/system/etc` as writable homedir for open-iscsi
* Drop `isns` since we never ran `isns` daemon

We could also split the `iscsid-wrapper` into two services, will do
after what comes out of
siderolabs/talos#10009.

Signed-off-by: Noel Georgi <[email protected]>
frezbo added a commit to frezbo/extensions that referenced this issue Jan 5, 2025
@frezbo
feat: rework iscsi-tools
bb09cc8 
* `tgtd` is only needed if exposing `iSCSI` targets from the host, not
needed when using as a client.
* Use `/system/etc` as writable homedir for open-iscsi
* Drop `isns` since we never ran `isns` daemon

We could also split the `iscsid-wrapper` into two services, will do
after what comes out of
siderolabs/talos#10009.

Signed-off-by: Noel Georgi <[email protected]>
@frezbo frezbo mentioned this issue Jan 5, 2025
Open
@frezbo
Copy link
Member Author

frezbo commented Jan 8, 2025

As per discussion we'll derive these from the machine id deterministically on each boot

frezbo added a commit to frezbo/talos that referenced this issue Jan 17, 2025
@frezbo
feat: generate iqn and nqn files.
1beeda0 
Generate deterministic IQN and NQN files based on `machine-id`.

Fixes: siderolabs#10009

Signed-off-by: Noel Georgi <[email protected]>
@frezbo frezbo linked a pull request Jan 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: generate iqn and nqn files. frezbo/talos
1 participant
@frezbo