[Unified Text Replacement] Swap characters view should be shown even …

…when there is no selection https://bugs.webkit.org/show_bug.cgi?id=274734 rdar://128712983 Reviewed by Wenson Hsieh. * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::selectionDidChange): Canonical link: https://commits.webkit.org/279387@main
sideshowbarker · May 28, 2024 · efa4d47 · efa4d47
1 parent 4d646a4
commit efa4d47
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Source/WebKit/UIProcess/mac/WebViewImpl.mm b/Source/WebKit/UIProcess/mac/WebViewImpl.mm
@@ -2794,8 +2794,10 @@ static String commandNameForSelector(SEL selector)
 #endif
 
 #if ENABLE(UNIFIED_TEXT_REPLACEMENT)
-    if (m_page->editorState().hasPostLayoutData() && wantsCompleteUnifiedTextReplacementBehavior() && m_page->editorState().selectionIsRange) {
-        auto selectionRect = m_page->editorState().postLayoutData->selectionBoundingRect;
+    if (wantsCompleteUnifiedTextReplacementBehavior()) {
+        auto isRange = m_page->editorState().hasPostLayoutData() && m_page->editorState().selectionIsRange;
+        auto selectionRect = isRange ? m_page->editorState().postLayoutData->selectionBoundingRect : IntRect { };
+
         scheduleShowSwapCharactersViewForSelectionRectOfView(selectionRect, m_view.getAutoreleased());
     }
 #endif