Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(redesign): new color table #1714

Open
wants to merge 19 commits into
base: docs/redesign-v2
Choose a base branch
from

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Feb 27, 2025

🆕 What is the new behavior?

Add new color table to the redesign.

Important

Workflows will not run because target branch exclude documentation package from workspace

Use pnpm start --filter documentation-redesign to start redesign documentation

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 4145c47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "documentation" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package "documentation-redesign" depends on the ignored package "angular-test-app", but "documentation-redesign" is not being ignored. Please add "documentation-redesign" to the `ignore` option.
The package "documentation-redesign" depends on the ignored package "react-test-app", but "documentation-redesign" is not being ignored. Please add "documentation-redesign" to the `ignore` option.
The package "documentation-redesign" depends on the ignored package "vue-test-app", but "documentation-redesign" is not being ignored. Please add "documentation-redesign" to the `ignore` option.
The package "documentation-redesign" depends on the ignored package "html-test-app", but "documentation-redesign" is not being ignored. Please add "documentation-redesign" to the `ignore` option.
The package "documentation-redesign" depends on the ignored package "ionic-test-app", but "documentation-redesign" is not being ignored. Please add "documentation-redesign" to the `ignore` option.
The package "documentation-redesign" depends on the ignored package "figma-plugin", but "documentation-redesign" is not being ignored. Please add "documentation-redesign" to the `ignore` option.

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra thick outline on the bottom of these boxes:
Screenshot 2025-02-28 at 16 49 01

@danielleroux
Copy link
Collaborator Author

There is an extra thick outline on the bottom of these boxes: Screenshot 2025-02-28 at 16 49 01

Should now be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants