fix(aggrid): Improve styling for indeterminate checkbox to be displayed in AG Grid header #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c62a90f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
danielleroux
requested changes
Mar 10, 2025
Comment on lines
+78
to
+79
| //TODO: Replace base64 encoded image with svg and css variables | ||
| //Encoded image: <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"><rect x="2" y="7" width="12" height="2" fill="#000028"/></svg> |
There was a problem hiding this comment.
I think we should remove the comments here. If you want to still have the todo create a jira ticket for that otherwise we will forget to remove this.
nuke-ellington
requested changes
Mar 10, 2025
| '@siemens/ix-aggrid': patch | ||
| --- | ||
|
|
||
| improve styling of aggrid for indeterminate checkbox to be displayed in grid header |
There was a problem hiding this comment.
Suggested change
| improve styling of aggrid for indeterminate checkbox to be displayed in grid header | |
| __AG Grid__: Improve styling of indeterminate checkbox to be displayed in grid header. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 What is the current behavior?
🆕 What is the new behavior?
Important note: The solution contains a workaround using base64 encoded SVG images (background + icon). This needs to be replaced by a human readable solution with SVG images that also include the correct CSS variables for the icon color.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs)pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support