setup: added script to auto install mtda aritfacts to system #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chombourger
reviewed
Feb 7, 2022
scripts/setup-mtda
Outdated
| dist_name() { | ||
| if [ -f /etc/os-release ]; then | ||
| # shellcheck disable=SC1091 | ||
| dist=$(. /etc/os-release && echo "${ID}") |
There was a problem hiding this comment.
it is not recommended to source /etc/os-release
chombourger
reviewed
Feb 7, 2022
chombourger
reviewed
Feb 7, 2022
scripts/setup-mtda
Outdated
Comment on lines
83
to
101
| docker_install() { | ||
| apt-get -y remove docker docker-engine docker.io containerd runc | ||
| apt-get update -y | ||
| apt-get -y install \ | ||
| ca-certificates \ | ||
| curl \ | ||
| gnupg \ | ||
| lsb-release | ||
| curl -fsSL https://download.docker.com/linux/debian/gpg | sudo gpg --dearmor -o /usr/share/keyrings/docker-archive-keyring.gpg | ||
| echo \ | ||
| "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/debian \ | ||
| $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list > /dev/null | ||
| apt-get update -y | ||
| apt-get -y install docker-ce docker-ce-cli containerd.io | ||
| /sbin/adduser $USER docker | ||
| systemctl enable docker | ||
| systemctl start docker | ||
| } |
There was a problem hiding this comment.
Debian and Ubuntu provide docker.io
boksheos
force-pushed
the
mtda-setup
branch
3 times, most recently
from
c5a3a2a
to
7e4fdf3
Compare
vj-kumar
reviewed
Feb 7, 2022
| # --------------------------------------------------------------------------------------------------------------------- | ||
|
|
||
| docker_install() { | ||
| apt-get -y remove docker docker-engine docker.io containerd runc |
There was a problem hiding this comment.
Not sure why we need to remove those?
boksheos
force-pushed
the
mtda-setup
branch
3 times, most recently
from
450fd84
to
aa04d57
Compare
github-actions
bot
requested review from
bikrambhola,
chombourger and
vj-kumar
Signed-off-by: Onkar Bokshe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an end user perspective this script will help to install mtda and its artifacts automatically following are the scripts features
Scope for improvement :
Note : This script is initial draft for mtda auto install which will help user in quick installation.
Signed-off-by: Onkar Bokshe [email protected]