Allow remote shared cache testing from a network isolated sandbox #1498

JakeSiFive · 2023-12-27T20:59:48Z

This is still very much a draft but it displays the basic components needed to get this idea to work.

Issues:

Each test has to use a distinct database name manually right now, it would be nice if these were auto selected
database names must be created prior to executing, it would be nice if the databases were created on the fly somehow
Managing the workflow with vendoring is a bit odd right now, it would be nice if vendored dep settings could be bind mounted into place instead
A non-rustup version of cargo has to be used to build this. I managed to get this working locally via a local install of a non-rustup toolchain. This might get a bit annoying if we don't have a way to download the version of cargo/rust that you're meant to build with
Right now things are just in the state I first got them working in, it would be nice if we could have a generic mechanism for running RSC commands in these environments

postgres-cmd-spec.json

postgres-cmd.sh

rust/rsc/src/rsc/main.rs

build.wake

scripts/which_wake_files

JakeSiFive · 2024-01-04T18:09:26Z

ok almost done, I'm gonna get these tests running in CI as the last step and then I'll take this off of draft. Go ahead and review the current form of it now because I only plan on adding code, not making modifications outside of review requests now.

rust/rsc/postgres-tests.wake

V-FEXrt · 2024-01-04T21:45:42Z

rust/rsc/src/rsc/main.rs

+    shim_db
+        .execute_unprepared(&format!("CREATE DATABASE {}", db))
+        .await?;
+    drop(shim_db);


Can you explain what drop is doing here/why it is needed?

I don't think its needed but it causes the shim_db to be droped before we create a new one so that we don't have two connections at once.

It also might help enforce that the follow up connection uses the same view version of the databases as the one we just created (e.g. drop might wait for transactions to be committed but I'm not too sure about that and it shouldn't be needed strictly here, I think the await is enough to know that the commit has happened and any new connections will see the new database.

V-FEXrt · 2024-01-05T17:00:18Z

rust/rsc/postgres-tests.wake

+        Some dir -> Pass "{dir}/bin"
+        None ->
+            require Some postgresPath = whichInEnvPath "postgres"
+            else failWithError "could not find postges on path"


typo: postges -> postgres

V-FEXrt · 2024-01-05T17:03:09Z

Makefile

@@ -80,6 +80,9 @@ test:		wake.db
 unittest:	all
 	$(WAKE_ENV) ./bin/wake --in test_wake runUnitTests

+remoteCacheTests:	all
+	$(WAKE_ENV) ./bin/wake -d -x 'testPostgres Unit'


nit: Do we need -d here? Also should testPostgres be in test_wake like the other tests?

-d It makes it a million times

Also I'm not going to mess with test_wake stuff right now since thats its own bag of worms

.github/workflows/build.yaml

V-FEXrt · 2024-01-05T19:53:56Z

.github/workflows/dockerfiles/alpine

@@ -1,6 +1,6 @@
 FROM alpine:3.14.0

-RUN apk add m4 g++ make pkgconf git tar xz gmp-dev re2-dev sqlite-dev fuse-dev ncurses-dev dash sqlite-static ncurses-static linux-headers jq
+RUN apk add m4 g++ make pkgconf git tar xz gmp-dev re2-dev sqlite-dev fuse-dev ncurses-dev dash sqlite-static ncurses-static linux-headers jq postgresql


Since we are building manually all these should be deleted

I think a lot of them are needed, just not the postgres dep

oh that is what I meant lol

"all these" -> postgres from all these different files not the entire dep list

oh gotcha, I'm going to remove postgres testing from the other deps for now

V-FEXrt · 2024-01-05T19:54:19Z

rust/rsc/postgres-cmd-spec.json

@@ -0,0 +1,43 @@
+{


Can this be deleted if we are generated the spec file?

yep, I just haven't gotten around to it, hold your horses on clean up comments.

V-FEXrt · 2024-01-05T22:59:17Z

.github/workflows/build.yaml

-        - name: Vendor remote cache deps
-          run: cd rust/rsc && cargo vendor --locked


looks like you deleted too much

basic working prototype

06b35e5

JakeSiFive requested review from colinschmidt and V-FEXrt December 27, 2023 20:59

JakeSiFive commented Dec 27, 2023

View reviewed changes

postgres-cmd-spec.json Outdated Show resolved Hide resolved

postgres-cmd-spec.json Outdated Show resolved Hide resolved

postgres-cmd.sh Outdated Show resolved Hide resolved

rust/rsc/src/rsc/main.rs Outdated Show resolved Hide resolved

build.wake Outdated Show resolved Hide resolved

a few more changes to clean things up

86958b8

V-FEXrt reviewed Jan 4, 2024

View reviewed changes

scripts/which_wake_files Outdated Show resolved Hide resolved

lots of good cleanup things

28232d6

JakeSiFive marked this pull request as ready for review January 4, 2024 18:10

JakeSiFive added 4 commits January 4, 2024 10:22

Add github actions testing for postgres testing

6a9d931

add postgres to host deps

ce5c06d

correct postgres package name

047e3b4

Try to get ubuntu working by setting it explicitly

908d9cb

V-FEXrt reviewed Jan 4, 2024

View reviewed changes

rust/rsc/postgres-tests.wake Outdated Show resolved Hide resolved

JakeSiFive added 2 commits January 4, 2024 12:43

Run cargo vendor first

ec478a8

whoops wrong dir

fd03d5f

V-FEXrt reviewed Jan 4, 2024

View reviewed changes

Checkout postgres directly

b6d4bf9

V-FEXrt reviewed Jan 5, 2024

View reviewed changes

V-FEXrt approved these changes Jan 5, 2024

View reviewed changes

V-FEXrt reviewed Jan 5, 2024

View reviewed changes

JakeSiFive added 7 commits January 5, 2024 09:58

checkout commit hash

ee5468a

remeber to CD!

9c3e58d

fix several issues lol

ad81647

format

e9c7c92

fail faster while debugging, change configure prefix

87a5939

don't worry about formatting for now

6b03f04

Use /var/tmp for checkout and install

152cd47

V-FEXrt reviewed Jan 5, 2024

View reviewed changes

.github/workflows/build.yaml Outdated Show resolved Hide resolved

Forgot to vendor deps

1492276

V-FEXrt reviewed Jan 5, 2024

View reviewed changes

JakeSiFive added 4 commits January 5, 2024 12:07

use pushd/popd

6a0a54e

Fix bad exit trap; use our own raw rust instead of rustup

6fc7834

forgot to specify remote in git fetch

3788d9b

clean up a bit

cfd62ac

V-FEXrt reviewed Jan 5, 2024

View reviewed changes

more clean up

4e4dbb0

JakeSiFive merged commit f2aed8e into master Jan 5, 2024
12 checks passed

JakeSiFive deleted the wakebox_env_for_postgres_testing branch January 5, 2024 23:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow remote shared cache testing from a network isolated sandbox #1498

Allow remote shared cache testing from a network isolated sandbox #1498

JakeSiFive commented Dec 27, 2023

JakeSiFive commented Jan 4, 2024

V-FEXrt Jan 4, 2024

JakeSiFive Jan 4, 2024

V-FEXrt Jan 5, 2024

V-FEXrt Jan 5, 2024

JakeSiFive Jan 5, 2024

V-FEXrt Jan 5, 2024

JakeSiFive Jan 5, 2024

V-FEXrt Jan 5, 2024

V-FEXrt Jan 5, 2024

JakeSiFive Jan 5, 2024

V-FEXrt Jan 5, 2024

JakeSiFive Jan 5, 2024

V-FEXrt Jan 5, 2024

		- name: Vendor remote cache deps
		run: cd rust/rsc && cargo vendor --locked

Allow remote shared cache testing from a network isolated sandbox #1498

Allow remote shared cache testing from a network isolated sandbox #1498

Conversation

JakeSiFive commented Dec 27, 2023

JakeSiFive commented Jan 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment