rsc: Allow file blobs in DbOnly Store #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinschmidt
approved these changes
Aug 21, 2024
| @@ -631,6 +632,10 @@ export def rscApiGetFileBlob ((CacheSearchBlob _ uri): CacheSearchBlob) (path: S | |||
| Pass path | |||
|
|
|||
| ## --- Helper functions --- | |||
|
|
|||
| def contentTypeFromSize size = | |||
| if size < 95 then Some "blob/small" else None | |||
There was a problem hiding this comment.
Did we determine ~100 was the right limit still?
There was a problem hiding this comment.
nope, we talked about 256 but I'm kicking that down the road
|
|
||
| def contentType = match (unsafe_stat file) | ||
| Pass (Stat _ _ size) -> contentTypeFromSize size | ||
| Fail _ -> None |
There was a problem hiding this comment.
Wondering if there is some benefit to failing earlier here rather than waiting for the uploadBlobRequest to fail if it can't stat the file?
There was a problem hiding this comment.
Maybe, I'm not sure which one happens first but I'll at it to the list of things to give a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows generic blobs to also be created as DbOnly blobs, including the deduping feature.
This change does require that the blob be
statd but that should essentially be free becausestatis atargetand we have to stat every file before upload anyways