Fix readdir recursive issue by switching to glob

package.json

@@ -15,7 +15,8 @@
   "license": "Apache-2.0",
   "dependencies": {
     "chalk": "^4.1.2",
-    "commander": "^12.1.0"
+    "commander": "^12.1.0",
+    "glob": "^11.0.0"
   },
   "devDependencies": {
     "@stylistic/eslint-plugin": "^2.9.0",
@@ -25,7 +26,6 @@
     "@typescript-eslint/parser": "^8.11.0",
     "eslint": "^8.57.1",
     "eslint-plugin-header": "^3.1.1",
-    "glob": "^11.0.0",
     "ts-node": "^10.9.2",
     "typescript": "^5.6.3"
   },

src/utils/filesystem.ts

@@ -20,6 +20,7 @@ import path from 'node:path';
 import readline from 'node:readline';
 import os from 'node:os';
 import { finished } from 'node:stream/promises';
+import { glob } from 'glob';
 
 const TEMP_FILE_EXTENSION: string = '.olly.tmp';
 
@@ -32,18 +33,19 @@ const TEMP_FILE_EXTENSION: string = '.olly.tmp';
  *  - path/to/dist/nested/folder/page1.js
  */
 export async function readdirRecursive(dir: string) {
-  const dirents = await readdir(
-    dir,
-    {
-      encoding: 'utf-8',
-      recursive: true,
-      withFileTypes: true
-    }
-  );
-  const filePaths = dirents
-    .filter(dirent => dirent.isFile())
-    .map(dirent => path.join(dirent.parentPath, dirent.name));
-  return filePaths;
+  // Using 'glob' instead of native 'readdir' due to:
+  //   https://github.com/nodejs/node/issues/48858
+  //   https://github.com/nodejs/node/issues/51773
+
+  // glob does not report some readdir errors (ENOTDIR, EACCES)
+  // that our user should know about, so try reading the dir before running glob
+  await readdir(dir);
+
+  const partialPaths = await glob('**/*', {
+    cwd: dir,
+    nodir: true,
+  });
+  return partialPaths.map(partialPath => path.join(dir, partialPath));
 }
 
 export function readlines(stream: ReadStream): AsyncIterable<string> {