Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint, lint:fix commands #17

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Add lint, lint:fix commands #17

merged 6 commits into from
Oct 23, 2024

Conversation

mvirgil
Copy link
Contributor

@mvirgil mvirgil commented Oct 23, 2024

Enforces recommended lint rules, Splunk header, and some basic formatting rules. We can revisit in future to adjust rules or add more strict formatting (e.g. prettier)

Using ESLint v8 to use the "legacy" config format. v9 supports legacy configs too, but it was not working nicely OOTB with editors' eslint plugins

@mvirgil mvirgil requested review from a team as code owners October 23, 2024 16:48
@mvirgil mvirgil marked this pull request as draft October 23, 2024 17:16
@mvirgil mvirgil marked this pull request as ready for review October 23, 2024 17:32
@tonzhan2 tonzhan2 merged commit 4fe94ef into main Oct 23, 2024
2 checks passed
@tonzhan2 tonzhan2 deleted the ci-lint-check branch October 23, 2024 17:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants