Implement "sourcemaps inject" command #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"sourcemaps inject" is given a directory, then: - determines which js and js.map files belong with each other - generates a "sourceMapId" for each of these pairs - injects a code snippet to the js file to indicate its "sourceMapId" --dry-run option is also added, to preview which files will be touched by the command Will cleanup logging code in a future PR
Will look into enabling eslint rule in future, because node:test runner does not play well with it
tonzhan2
approved these changes
Oct 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"sourcemaps inject" is given a directory, then:
--dry-run option is also added, to preview which files will be touched by the command
Will cleanup logging code in a future PR