Add "sourcemaps upload" command using a mock call #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error handling can be improved when integrating with the real API call
mvirgil
commented
Dec 12, 2024
mvirgil
commented
Dec 13, 2024
| .requiredOption( | ||
| '--realm <value>', | ||
| 'Realm for your organization (example: us0). Can also be set using the environment variable O11Y_REALM', | ||
| process.env.O11Y_REALM |
There was a problem hiding this comment.
If we want to default as us0, we could replace with `process.env.O11Y_REALM || 'us0'
Abinet18
reviewed
Dec 13, 2024
Abinet18
reviewed
Dec 17, 2024
| .summary(`Upload source maps to Splunk Observability Cloud`) | ||
| .description(uploadDescription) | ||
| .requiredOption( | ||
| '--directory <path>', |
There was a problem hiding this comment.
Should there also be an option to upload a specific file ? Directory could contain multiple sourcemaps that may not be needed, or it may contain multiple versions of a sourcemap , if so it may not be effective to upload all of them ?
There was a problem hiding this comment.
This is a good suggestion for enhancement. We could have some wider conversation and add in a follow-up PR if needed.
Some other options could be to use additional option like --include or --exclude to let user refine the file selection
Abinet18
approved these changes
Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting the file upload progress still needs improvement (currently prints using "bytes" as the unit)
Error handling can be improved when integrating with the real API call
Dry run can be implemented in future PR