Ingest cluster receiver events into index defined in annotation #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoravong
reviewed
Oct 1, 2024
functional_tests/testdata_histogram/expected/v1.29/controller_manager_metrics.yaml
Outdated
Show resolved
Hide resolved
jvoravong
reviewed
Oct 10, 2024
| @@ -73,6 +73,7 @@ receivers: | |||
| {{- end }} | |||
|
|
|||
| processors: | |||
| {{- include "splunk-otel-collector.k8sClusterReceiverAttributesProcessor" . | nindent 2 }} | |||
There was a problem hiding this comment.
Lets refactor this a little for a couple reasons. This configurations will always be included even if not used and we could relocate it to be closer to similar configurations like it.
- Move this content to around lines 92-112
- Add conditional clauses appropriately to make this configuration content only included when it is used. Something like this.
{{- if and $clusterReceiver.eventsEnabled (eq (include "splunk-otel-collector.logsEnabled" .) "true") }}
{{- include "splunk-otel-collector.k8sClusterReceiverAttributesProcessor" . | nindent 2 }}
{{- end }}`
jvoravong
reviewed
Oct 10, 2024
| @@ -209,6 +209,34 @@ k8sattributes: | |||
| {{- include "splunk-otel-collector.addExtraLabels" . | nindent 6 }} | |||
| {{- end }} | |||
| {{- end }} | |||
| {{- define "splunk-otel-collector.k8sClusterReceiverAttributesProcessor" -}} | |||
| k8sattributes/clusterReceiver: | |||
There was a problem hiding this comment.
If we're adding this change, we need to address some cleanup and refactor work to prevent code duplication related to setting Kubernetes attributes:
- Remove or replace redundant attribute setting: We should clean up any attributes set using the previous method that will now be handled by the k8sattributes processor. Try to only set the k8s attributes using one processor.
- Clean up unused environment variables: The environment variables in the cluster receiver deployment that are no longer used to set attributes the old way should also be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ingest cluster receiver events into index defined in annotation
Link to Splunk idea:
Testing: Tested manually
Documentation: