Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourcemap upload feature to webpack plugin #927

Draft
wants to merge 1 commit into
base: bundler-plugin
Choose a base branch
from

Conversation

mvirgil
Copy link

@mvirgil mvirgil commented Jan 17, 2025

Tested locally with olly RUM UI project

Description

Add "upload" functionality to the webpack plugin.

When this webpack plugin is enabled, it will automatically upload source map assets
to the backend once the build is finished.

Example output in the webpack logs

<i> [OllyWebPlugin] Uploading 24 source maps to http://localhost:8088/v1/sourcemaps/id/{id}
<w> [OllyWebPlugin] 413 Request Entity Too Large
<w> [OllyWebPlugin] Unable to upload rumModule.cf999b4569620b6898e5.js.map
<i> [OllyWebPlugin] Successfully uploaded 23 source map(s)
<e> [OllyWebPlugin] Failed to upload 1 source map(s)
[OllyWebPlugin] Uploading finished

Type of change

Delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Chore or internal change (changes not visible to the consumers of the package)

How has this been tested?

Delete options that are not relevant.

  • Manual testing

Manually tested with the O11y RUM webpack build.
Separate JIRA task for handling integration testing
Planning to remove some new util function soon (for computing source map ID) after
the inject command is updated, so omitted unit test for those as well.

Tested locally with olly RUM UI project
Copy link
Contributor

@shumone shumone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants