fix: Add 'http.response.status_code' to documentFetch span. #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
srv-gh-o11y-gdi-cla
added a commit
to splunk/cla-agreement
that referenced
this pull request
Jan 19, 2025
Joozty
reviewed
Jan 20, 2025
| @@ -8,7 +8,8 @@ | |||
| "pretty": true, | |||
| "resolveJsonModule": true, | |||
| "target": "ES2017", | |||
| "types": ["node"] | |||
| "types": ["node"], | |||
| "skipLibCheck": true | |||
There was a problem hiding this comment.
we should remove this once we upgrade web-vitals package
Joozty
approved these changes
Jan 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add 'http.response.status_code' to documentFetch span.
Type of change
Delete options that are not relevant.
How has this been tested?
Delete options that are not relevant.