Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document: .i18nrc is conf file, not .babelrc #10

Merged
merged 2 commits into from
Mar 3, 2017
Merged

Conversation

TimKam
Copy link
Contributor

@TimKam TimKam commented Mar 1, 2017

Extracting msgids fails if no .i18nrc file is provided.

I re-ordered the setup items, because it seems that the .i18nrc file location depends on the path provided to i18n-extract (which I don't fully understand).

Extracting msgids fails if no .i18nrc file is provided
@frontendphil
Copy link
Contributor

Wouldn't it be better to try to solve the real issue? Either by using good defaults for the entries in the .i18nrc or by always looking up the tree for a .i18nrc and using this one instead? This would match the behaviour of other .rcfiles.

@TimKam
Copy link
Contributor Author

TimKam commented Mar 2, 2017

I agree and created #11 for this.
Anyway, I suppose the changes here are still ok.

README.md Outdated
}
```

Create the file `.i18nrc` and add a configuration object for gettext message extraction:

```json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should without the "extra" and "gettext" wrapping

@jfschwarz jfschwarz merged commit 9ec659d into master Mar 3, 2017
@jfschwarz jfschwarz deleted the TimKam-patch-1 branch March 3, 2017 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants