Decided msg handling #139
Open
Decided msg handling #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dknopik
reviewed
Feb 17, 2025
dknopik
reviewed
Feb 18, 2025
anchor/common/qbft/src/lib.rs
Outdated
| fn received_decided(&mut self, wrapped_msg: WrappedQbftMessage) { | ||
| // Make sure we have a quorum of signatures | ||
| if wrapped_msg.signed_message.operator_ids().len() >= self.config().quorum_size() { | ||
| self.received_decided(wrapped_msg); |
There was a problem hiding this comment.
Wait, this is a recursive call.
There was a problem hiding this comment.
Im not sure why this is here, will remove and fix the condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Other part of #103
Proposed Changes
A pretty simple implementation. If we recieve a decided message, which is identified by having > 1 signature, we can immediately complete our instance. All verification is to be done upstream. The only remaining part of this is to validate the signatures in #137