Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sigstore-ruby, archive ruby-sigstore #441

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

haydentherapper
Copy link
Contributor

A new implementation of the Ruby client has been implemented and will be donated to the Sigstore org. The previous implementation is no longer maintained, so it will be archived.

Also adds maintainers for the new repo based on offline discussion.

Closes sigstore/TSC#50

Summary

Release Note

Documentation

@haydentherapper haydentherapper requested a review from a team as a code owner May 13, 2024 14:55
@haydentherapper
Copy link
Contributor Author

cc @woodruffw @segiddins

@haydentherapper
Copy link
Contributor Author

sync-changes failing at HEAD, filed #442

@woodruffw
Copy link
Member

Thanks @haydentherapper!

@haydentherapper
Copy link
Contributor Author

haydentherapper commented May 20, 2024

I realized the failed test here is because we're deleting a user, which is WAI. However because we updated pulumi recently, we have a diff as seen in https://github.com/sigstore/community/actions/runs/8905874264. Working with a TSC member to kick off a sync from HEAD before pushing this through, then we'll coordinate on the repo transfer.

@@ -2341,6 +2341,53 @@ repositories:
dismissalRestrictions:
- sigstore-rs-codeowners
webCommitSignoffRequired: true
- name: sigstore-ruby
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be a new repo? i opened and that redirect to ruby-sigstore

let sync that, maybe need some manual operations

@bobcallaway
Copy link
Member

what else do we need to do here to get this closed out?

@haydentherapper
Copy link
Contributor Author

Sync output now looks good, only has the changes specified here. Remaining steps:

  1. @segiddins to initiate transfer to sigstore/sigstore-ruby
  2. Admin unlocks user being deleted
  3. Admin manually syncs pulumi
  4. Verify with @segiddins that repo settings are as expected

A new implementation of the Ruby client has been implemented and will be
donated to the Sigstore org. The previous implementation is no longer
maintained, so it will be archived.

Also adds maintainers for the new repo based on offline discussion.

Closes sigstore/TSC#50

Signed-off-by: Hayden Blauzvern <[email protected]>
Copy link

🍹 preview on sigstore-github-sync/sigstore/github-prod

Pulumi report
Previewing update (sigstore/github-prod)

View Live: https://app.pulumi.com/sigstore/sigstore-github-sync/github-prod/previews/9448a4ed-0b48-404f-958a-8580cafe5e3f

@ Previewing update.....
pulumi:pulumi:Stack: (same)
[urn=urn:pulumi:github-prod::sigstore-github-sync::pulumi:pulumi:Stack::sigstore-github-sync-github-prod]
+ github:index/membership:Membership: (create) 🔒
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/membership:Membership::segiddins]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    downgradeOnDestroy: false
    role              : "member"
    username          : "segiddins"
+ github:index/teamMembership:TeamMembership: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamMembership:TeamMembership::segiddins-codeowners-ruby-sigstore]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    role      : "member"
    teamId    : "4728095"
    username  : "segiddins"
+ github:index/teamMembership:TeamMembership: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamMembership:TeamMembership::woodruffw-codeowners-ruby-sigstore]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    role      : "member"
    teamId    : "4728095"
    username  : "woodruffw"
~ github:index/repository:Repository: (update) 🔒
    [id=root-signing]
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/repository:Repository::root-signing]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
  ~ vulnerabilityAlerts: true => false
+ github:index/branchDefault:BranchDefault: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/branchDefault:BranchDefault::sigstore-ruby]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    branch    : "main"
    rename    : false
    repository: "sigstore-ruby"
+ github:index/repository:Repository: (create) 🔒
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/repository:Repository::sigstore-ruby]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    allowAutoMerge          : true
    allowMergeCommit        : false
    allowRebaseMerge        : true
    allowSquashMerge        : true
    archived                : false
    autoInit                : false
    deleteBranchOnMerge     : true
    description             : "Pure-ruby implementation of sigstore verification"
    hasDiscussions          : false
    hasDownloads            : true
    hasIssues               : true
    hasProjects             : true
    hasWiki                 : true
    homepageUrl             : ""
    isTemplate              : false
    licenseTemplate         : ""
    mergeCommitMessage      : "PR_TITLE"
    mergeCommitTitle        : "MERGE_MESSAGE"
    name                    : "sigstore-ruby"
    squashMergeCommitMessage: "COMMIT_MESSAGES"
    squashMergeCommitTitle  : "COMMIT_OR_PR_TITLE"
    topics                  : []
    visibility              : "public"
    vulnerabilityAlerts     : true
    webCommitSignoffRequired: true
+ github:index/teamRepository:TeamRepository: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamRepository:TeamRepository::sigstore-ruby-codeowners-ruby-sigstore]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    permission: "maintain"
    repository: "sigstore-ruby"
    teamId    : "4728095"
+ github:index/teamRepository:TeamRepository: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamRepository:TeamRepository::sigstore-ruby-triage]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    permission: "triage"
    repository: "sigstore-ruby"
    teamId    : "5643322"
+ github:index/branchProtection:BranchProtection: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/branchProtection:BranchProtection::sigstore-ruby-main]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    allowsDeletions              : false
    allowsForcePushes            : false
    enforceAdmins                : true
    lockBranch                   : false
    pattern                      : "main"
    repositoryId                 : output<string>
    requireConversationResolution: false
    requireSignedCommits         : false
    requiredLinearHistory        : true
    requiredPullRequestReviews   : [
        [0]: {
            dismissStaleReviews         : true
            dismissalRestrictions       : [
                [0]: "MDQ6VGVhbTQ3MjgwOTU="
            ]
            pullRequestBypassers        : []
            requireCodeOwnerReviews     : true
            requireLastPushApproval     : true
            requiredApprovingReviewCount: 1
            restrictDismissals          : true
        }
    ]
    requiredStatusChecks         : [
        [0]: {
            contexts  : [
                [0]: "DCO"
            ]
            strict    : true
        }
    ]
    restrictPushes               : [
        [0]: {
            blocksCreations: true
            pushAllowances : [
                [0]: "MDQ6VGVhbTQ3MjgwOTU="
            ]
        }
    ]
@ Previewing update....
- github:index/membership:Membership: (delete)
    [id=sigstore:endorama]
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/membership:Membership::endorama]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    downgradeOnDestroy: false
    role              : "member"
    username          : "endorama"
- github:index/teamMembership:TeamMembership: (delete)
    [id=4728095:lukehinds]
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamMembership:TeamMembership::lukehinds-codeowners-ruby-sigstore]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    role      : "maintainer"
    teamId    : "4728095"
    username  : "lukehinds"
- github:index/teamMembership:TeamMembership: (delete)
    [id=4728095:endorama]
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamMembership:TeamMembership::endorama-codeowners-ruby-sigstore]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    role      : "member"
    teamId    : "4728095"
    username  : "endorama"
Resources:
+ 8 to create
~ 1 to update
- 3 to delete
12 changes. 593 unchanged

@haydentherapper haydentherapper merged commit c8da788 into sigstore:main Jun 25, 2024
2 checks passed
@haydentherapper haydentherapper deleted the ruby branch June 25, 2024 00:08
@cpanato
Copy link
Member

cpanato commented Jun 25, 2024

i will fix the automation, we need to import the resources, if is an existing one we need to import and cannot add as is, adding config is only for non-existing

@haydentherapper @bobcallaway

@cpanato
Copy link
Member

cpanato commented Jun 25, 2024

all done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Donation of Ruby implementation
4 participants