-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix team ID for model-transparency
team
#456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Maruseac <[email protected]>
🍹
|
haydentherapper
approved these changes
Jun 17, 2024
cpanato
approved these changes
Jun 18, 2024
bobcallaway
approved these changes
Jun 18, 2024
mihaimaruseac
added a commit
to mihaimaruseac/sigstore-community
that referenced
this pull request
Jun 20, 2024
Last time, when I tried to update the `model_transparency` repo, I added a `model_transparency` team and added it to the repo in the same PR (sigstore#454), with a plan to fix team ID in the next one (sigstore#456). This actually caused a problem: the `model_transparency_codeowners` team lost access to the repository. This was because the team ID was reused, so Pulumi removed permissions when creating the new team. Signed-off-by: Mihai Maruseac <[email protected]>
mihaimaruseac
added a commit
to mihaimaruseac/sigstore-community
that referenced
this pull request
Jun 21, 2024
Last time, when I tried to update the `model_transparency` repo, I added a `model_transparency` team and added it to the repo in the same PR (sigstore#454), with a plan to fix team ID in the next one (sigstore#456). This actually caused a problem: the `model_transparency_codeowners` team lost access to the repository. This was because the team ID was reused, so Pulumi removed permissions when creating the new team. Signed-off-by: Mihai Maruseac <[email protected]>
haydentherapper
pushed a commit
that referenced
this pull request
Jun 24, 2024
Last time, when I tried to update the `model_transparency` repo, I added a `model_transparency` team and added it to the repo in the same PR (#454), with a plan to fix team ID in the next one (#456). This actually caused a problem: the `model_transparency_codeowners` team lost access to the repository. This was because the team ID was reused, so Pulumi removed permissions when creating the new team. Signed-off-by: Mihai Maruseac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #454 we added a new team but we could not see the team ID until after the Pulumi sync. Similar to #421, we got it from inspecting the avatar of the team at https://github.com/orgs/sigstore/teams/model-transparency.
Release Note
NONE
Documentation
NONE