Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix team ID for model-transparency team #456

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

mihaimaruseac
Copy link
Contributor

Summary

In #454 we added a new team but we could not see the team ID until after the Pulumi sync. Similar to #421, we got it from inspecting the avatar of the team at https://github.com/orgs/sigstore/teams/model-transparency.

Release Note

NONE

Documentation

NONE

@mihaimaruseac mihaimaruseac requested a review from a team as a code owner June 17, 2024 18:09
Copy link

🍹 preview on sigstore-github-sync/sigstore/github-prod

Pulumi report
Previewing update (sigstore/github-prod)

View Live: https://app.pulumi.com/sigstore/sigstore-github-sync/github-prod/previews/13158652-6e6f-4ca3-9758-fb70693c931e

@ Previewing update.....
pulumi:pulumi:Stack: (same)
[urn=urn:pulumi:github-prod::sigstore-github-sync::pulumi:pulumi:Stack::sigstore-github-sync-github-prod]
+-github:index/teamRepository:TeamRepository: (replace)
    [id=9730895:model-transparency]
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamRepository:TeamRepository::model-transparency-model-transparency]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
  ~ teamId: "9730895" => "10329477"
Resources:
+-1 to replace
590 unchanged

@cpanato cpanato requested a review from bobcallaway June 18, 2024 10:11
@bobcallaway bobcallaway merged commit 2d5eccf into sigstore:main Jun 18, 2024
2 checks passed
mihaimaruseac added a commit to mihaimaruseac/sigstore-community that referenced this pull request Jun 20, 2024
Last time, when I tried to update the `model_transparency` repo, I added
a `model_transparency` team and added it to the repo in the same PR
(sigstore#454), with a plan to fix team ID in the next one (sigstore#456). This actually
caused a problem: the `model_transparency_codeowners` team lost access
to the repository.

This was because the team ID was reused, so Pulumi removed permissions
when creating the new team.

Signed-off-by: Mihai Maruseac <[email protected]>
mihaimaruseac added a commit to mihaimaruseac/sigstore-community that referenced this pull request Jun 21, 2024
Last time, when I tried to update the `model_transparency` repo, I added
a `model_transparency` team and added it to the repo in the same PR
(sigstore#454), with a plan to fix team ID in the next one (sigstore#456). This actually
caused a problem: the `model_transparency_codeowners` team lost access
to the repository.

This was because the team ID was reused, so Pulumi removed permissions
when creating the new team.

Signed-off-by: Mihai Maruseac <[email protected]>
haydentherapper pushed a commit that referenced this pull request Jun 24, 2024
Last time, when I tried to update the `model_transparency` repo, I added
a `model_transparency` team and added it to the repo in the same PR
(#454), with a plan to fix team ID in the next one (#456). This actually
caused a problem: the `model_transparency_codeowners` team lost access
to the repository.

This was because the team ID was reused, so Pulumi removed permissions
when creating the new team.

Signed-off-by: Mihai Maruseac <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants