Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update community codeowners #458

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Update community codeowners #458

merged 1 commit into from
Jun 20, 2024

Conversation

haydentherapper
Copy link
Contributor

@haydentherapper haydentherapper commented Jun 18, 2024 •
edited
Loading

This adds both org admins as maintainers of the community repo to help with reviews.

Summary

Release Note

Documentation

@haydentherapper haydentherapper requested a review from a team as a code owner June 18, 2024 00:02
@haydentherapper haydentherapper marked this pull request as draft June 18, 2024 00:04
@haydentherapper haydentherapper force-pushed the community-codeowners branch 2 times, most recently from 3b78b7b to d19e11d Compare June 18, 2024 01:16
cpanato
cpanato reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say add myself as well :)

@haydentherapper
Update community codeowners
2cc8c8b 
This adds both org admins as maintainers of the community repo
to help with reviews.

Signed-off-by: Hayden Blauzvern <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

🍹 preview on sigstore-github-sync/sigstore/github-prod

Pulumi report 
Previewing update (sigstore/github-prod)

View Live: https://app.pulumi.com/sigstore/sigstore-github-sync/github-prod/previews/bf66eb08-81fd-4d2b-89d3-7db9a273b678

@ Previewing update.....
pulumi:pulumi:Stack: (same)
[urn=urn:pulumi:github-prod::sigstore-github-sync::pulumi:pulumi:Stack::sigstore-github-sync-github-prod]
+ github:index/teamMembership:TeamMembership: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamMembership:TeamMembership::haydentherapper-community-codeowners]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    role      : "member"
    teamId    : "10339798"
    username  : "haydentherapper"
+ github:index/teamMembership:TeamMembership: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamMembership:TeamMembership::cpanato-community-codeowners]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    role      : "member"
    teamId    : "10339798"
    username  : "cpanato"
+ github:index/teamRepository:TeamRepository: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamRepository:TeamRepository::community-community-codeowners]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
    permission: "maintain"
    repository: "community"
    teamId    : "10339798"
~ github:index/branchProtection:BranchProtection: (update)
    [id=BPR_kwDOFHiDJM4DA1Fs]
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/branchProtection:BranchProtection::community-main]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_1::c4864a06-f2c2-4a7a-b9b8-d9a955761310]
  ~ requiredPullRequestReviews: [
      ~ [0]: {
              ~ dismissalRestrictions: [
                    [0]: "MDQ6VGVhbTQ1NjMzOTE="
                  + [1]: "T_kwDOBDzYIc4AncXW"
                ]
            }
    ]
  ~ restrictPushes            : [
      ~ [0]: {
              ~ pushAllowances: [
                    [0]: "MDQ6VGVhbTQ1NjMzOTE="
                  + [1]: "T_kwDOBDzYIc4AncXW"
                ]
            }
    ]
@ Previewing update....
Resources:
+ 3 to create
~ 1 to update
4 changes. 592 unchanged

haydentherapper
haydentherapper commented Jun 18, 2024
View reviewed changes
CODEOWNERS
@@ -1 +1 @@
* @sigstore/core-team
* @sigstore/core-team @sigstore/community-codeowners
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error will resolve once PR is merged, since community-owners will have write perms added.

@haydentherapper haydentherapper changed the title Add self as codeowner for sigstore/community Update community codeowners Jun 18, 2024
@haydentherapper haydentherapper marked this pull request as ready for review June 18, 2024 20:06
@haydentherapper
Copy link
Contributor Author

@cpanato added you as well

@bobcallaway
Copy link
Member

can we get a couple other reviews from @sigstore/core-team please?

@bobcallaway bobcallaway merged commit 7d9634e into sigstore:main Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerschrock spencerschrock spencerschrock left review comments

@bobcallaway bobcallaway bobcallaway approved these changes

@SantiagoTorres SantiagoTorres SantiagoTorres approved these changes

@cpanato cpanato cpanato approved these changes

@priyawadhwa priyawadhwa priyawadhwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@haydentherapper @bobcallaway @SantiagoTorres @cpanato @spencerschrock @priyawadhwa