Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some required checks from root-signing for migration #477

Conversation

jku
Copy link
Member

@jku jku commented Aug 12, 2024

"test" and "lint" do not exist anymore in future root-signing : remove them from required list

There are a few new checks we should make required but that only makes sense after the workflows are running.

This fixes sigstore/root-signing#1314 and is part of sigstore/root-signing#1247

CC @haydentherapper

"test" and "lint" do not exist anymore: remove them

There are a few new checks we should make required but that only makes
sense after the workflows are running.

Signed-off-by: Jussi Kukkonen <[email protected]>
@jku jku requested review from a team as code owners August 12, 2024 12:04
Copy link

🍹 preview on sigstore-github-sync/sigstore/github-prod

Pulumi report
  Previewing update (sigstore/github-prod)

View Live: https://app.pulumi.com/sigstore/sigstore-github-sync/github-prod/previews/7bb997f5-4c84-4e45-81b5-20b74eaa1211

@ Previewing update....
pulumi:pulumi:Stack: (same)
  [urn=urn:pulumi:github-prod::sigstore-github-sync::pulumi:pulumi:Stack::sigstore-github-sync-github-prod]
  ~ github:index/teamMembership:TeamMembership: (update)
      [id=6693572:bobcallaway]
      [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamMembership:TeamMembership::bobcallaway-sigstore-oncall]
      [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_3::dfb01c0f-bb2a-45c2-9d92-e6152b5cee06]
    ~ role: "maintainer" => "member"
@ Previewing update....
  ~ github:index/branchProtection:BranchProtection: (update)
      [id=BPR_kwDOFotDCM4DA1RL]
      [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/branchProtection:BranchProtection::root-signing-main]
      [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_3::dfb01c0f-bb2a-45c2-9d92-e6152b5cee06]
    ~ requiredStatusChecks: [
        ~ [0]: {
                ~ contexts: [
                    - [0]: "lint"
                    ~ [1]: "test" => "yamllint"
                    - [2]: "DCO"
                    - [3]: "yamllint"
                  ]
              }
      ]
@ Previewing update....
Resources:
  ~ 2 to update
  590 unchanged
  

@jku
Copy link
Member Author

jku commented Aug 12, 2024

@bobcallaway for some reason the pulumi update includes an unrelated ~ role: "maintainer" => "member" for TeamMembership::bobcallaway-sigstore-oncall 🤷

@bobcallaway
Copy link
Member

bobcallaway commented Aug 12, 2024

@bobcallaway for some reason the pulumi update includes an unrelated ~ role: "maintainer" => "member" for TeamMembership::bobcallaway-sigstore-oncall 🤷

I think that's related to #476 ; @haydentherapper can you look into this please?

@haydentherapper
Copy link
Contributor

I'm not sure why it has Bob as a team maintainer, the team membership is defined as a member, not a maintainer. Let's apply this, and if we see it again, then I'll look more.

@haydentherapper haydentherapper merged commit b17a9c2 into sigstore:main Aug 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub settings: remove required checks for migration
3 participants