Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: use a venv to prevent PEP 668 errors #145

Merged
merged 4 commits into from
Jul 4, 2024
Merged

action: use a venv to prevent PEP 668 errors #145

merged 4 commits into from
Jul 4, 2024

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Jul 3, 2024

WIP.

Closes #144.

@woodruffw woodruffw self-assigned this Jul 3, 2024
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw marked this pull request as ready for review July 3, 2024 13:21
@woodruffw
Copy link
Member Author

This is good to go. To summarize:

We now isolate this action's Python dependencies inside of a virtual environment, rather than using either the distribution or configured Python's user packages site. This makes us both compatible with PEP 668 (the source of the error) and avoids the (slim) likelihood of conflict with other steps running in the same job.

(Plumbing everything through this new venv is a minor adventure, since Windows and *nix venvs have slightly different directory layouts. But the selftests confirm that the specialization for both works.)

This has been true for a while.

Signed-off-by: William Woodruff <[email protected]>
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, This looks surprisingly complicated to deal with. I don't have a better suggestion so let's go with that

@jku jku merged commit 1ddeb82 into main Jul 4, 2024
33 checks passed
@jku jku deleted the ww/pep-668 branch July 4, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action fails on ubuntu-24.04 with "This environment is externally managed"
2 participants