Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a simple experiment to vary chunk size, built on top of #306
So far, the experiment has shown similar results on two different machines (ARM64 macOS and x86 Linux), and on two different models.
Two factors may limit what models can be benchmarked:
timeit.timeit
disables garbage collection, so even if smaller buffers are used, older ones may stay around in memory.The hashing algorithm was left as SHA256 based on the results from the hashing experiment.
The result of the benchmarks suggest increasing the chunk size to at least 128 KB (131072) with a 1MB read size producing the best results in this benchmark. Happy to do that in a follow-up PR, or this one.
Release Note
NONE
Documentation
NONE