Skip to content

Commit

Permalink
protos: drop EXPERIMENTAL_ prefix (#214)
Browse files Browse the repository at this point in the history 
* drop EXPERIMENTAL_ prefix

Signed-off-by: William Woodruff <[email protected]>

* gen, protos: warning language

Signed-off-by: William Woodruff <[email protected]>

---------

Signed-off-by: William Woodruff <[email protected]>
  • Loading branch information
@woodruffw
woodruffw authored Feb 7, 2024
1 parent 7e73a23 commit 3a1daa1
Show file tree
Hide file tree
Showing 17 changed files with 117 additions and 71 deletions.
4 changes: 2 additions & 2 deletions gen/jsonschema/schemas/ArtifactVerificationOptions.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@
"PKIX_ECDSA_P521_SHA_512",
"PKIX_ED25519",
"PKIX_ED25519_PH",
"EXPERIMENTAL_LMS_SHA256",
"EXPERIMENTAL_LMOTS_SHA256"
"LMS_SHA256",
"LMOTS_SHA256"
],
"type": "string",
"title": "Public Key Details",
Expand Down
4 changes: 2 additions & 2 deletions gen/jsonschema/schemas/Input.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,8 @@
"PKIX_ECDSA_P521_SHA_512",
"PKIX_ED25519",
"PKIX_ED25519_PH",
"EXPERIMENTAL_LMS_SHA256",
"EXPERIMENTAL_LMOTS_SHA256"
"LMS_SHA256",
"LMOTS_SHA256"
],
"type": "string",
"title": "Public Key Details",
Expand Down
4 changes: 2 additions & 2 deletions gen/jsonschema/schemas/PublicKey.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
"PKIX_ECDSA_P521_SHA_512",
"PKIX_ED25519",
"PKIX_ED25519_PH",
"EXPERIMENTAL_LMS_SHA256",
"EXPERIMENTAL_LMOTS_SHA256"
"LMS_SHA256",
"LMOTS_SHA256"
],
"type": "string",
"title": "Public Key Details",
Expand Down
4 changes: 2 additions & 2 deletions gen/jsonschema/schemas/PublicKeyIdentities.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
"PKIX_ECDSA_P521_SHA_512",
"PKIX_ED25519",
"PKIX_ED25519_PH",
"EXPERIMENTAL_LMS_SHA256",
"EXPERIMENTAL_LMOTS_SHA256"
"LMS_SHA256",
"LMOTS_SHA256"
],
"type": "string",
"title": "Public Key Details",
Expand Down
4 changes: 2 additions & 2 deletions gen/jsonschema/schemas/TransparencyLogInstance.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@
"PKIX_ECDSA_P521_SHA_512",
"PKIX_ED25519",
"PKIX_ED25519_PH",
"EXPERIMENTAL_LMS_SHA256",
"EXPERIMENTAL_LMOTS_SHA256"
"LMS_SHA256",
"LMOTS_SHA256"
],
"type": "string",
"title": "Public Key Details",
Expand Down
4 changes: 2 additions & 2 deletions gen/jsonschema/schemas/TrustedRoot.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@
"PKIX_ECDSA_P521_SHA_512",
"PKIX_ED25519",
"PKIX_ED25519_PH",
"EXPERIMENTAL_LMS_SHA256",
"EXPERIMENTAL_LMOTS_SHA256"
"LMS_SHA256",
"LMOTS_SHA256"
],
"type": "string",
"title": "Public Key Details",
Expand Down
67 changes: 39 additions & 28 deletions gen/pb-go/common/v1/sigstore_common.pb.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 12 additions & 3 deletions gen/pb-python/sigstore_protobuf_specs/dev/sigstore/common/v1/__init__.py
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions gen/pb-ruby/lib/sigstore_common_pb.rb
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions gen/pb-rust/schemas/ArtifactVerificationOptions.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@
"PKIX_ECDSA_P521_SHA_512",
"PKIX_ED25519",
"PKIX_ED25519_PH",
"EXPERIMENTAL_LMS_SHA256",
"EXPERIMENTAL_LMOTS_SHA256"
"LMS_SHA256",
"LMOTS_SHA256"
],
"type": "string",
"title": "Public Key Details",
Expand Down
4 changes: 2 additions & 2 deletions gen/pb-rust/schemas/Input.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,8 @@
"PKIX_ECDSA_P521_SHA_512",
"PKIX_ED25519",
"PKIX_ED25519_PH",
"EXPERIMENTAL_LMS_SHA256",
"EXPERIMENTAL_LMOTS_SHA256"
"LMS_SHA256",
"LMOTS_SHA256"
],
"type": "string",
"title": "Public Key Details",
Expand Down
4 changes: 2 additions & 2 deletions gen/pb-rust/schemas/PublicKey.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
"PKIX_ECDSA_P521_SHA_512",
"PKIX_ED25519",
"PKIX_ED25519_PH",
"EXPERIMENTAL_LMS_SHA256",
"EXPERIMENTAL_LMOTS_SHA256"
"LMS_SHA256",
"LMOTS_SHA256"
],
"type": "string",
"title": "Public Key Details",
Expand Down
4 changes: 2 additions & 2 deletions gen/pb-rust/schemas/PublicKeyIdentities.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
"PKIX_ECDSA_P521_SHA_512",
"PKIX_ED25519",
"PKIX_ED25519_PH",
"EXPERIMENTAL_LMS_SHA256",
"EXPERIMENTAL_LMOTS_SHA256"
"LMS_SHA256",
"LMOTS_SHA256"
],
"type": "string",
"title": "Public Key Details",
Expand Down
4 changes: 2 additions & 2 deletions gen/pb-rust/schemas/TransparencyLogInstance.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@
"PKIX_ECDSA_P521_SHA_512",
"PKIX_ED25519",
"PKIX_ED25519_PH",
"EXPERIMENTAL_LMS_SHA256",
"EXPERIMENTAL_LMOTS_SHA256"
"LMS_SHA256",
"LMOTS_SHA256"
],
"type": "string",
"title": "Public Key Details",
Expand Down
4 changes: 2 additions & 2 deletions gen/pb-rust/schemas/TrustedRoot.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@
"PKIX_ECDSA_P521_SHA_512",
"PKIX_ED25519",
"PKIX_ED25519_PH",
"EXPERIMENTAL_LMS_SHA256",
"EXPERIMENTAL_LMOTS_SHA256"
"LMS_SHA256",
"LMOTS_SHA256"
],
"type": "string",
"title": "Public Key Details",
Expand Down
36 changes: 25 additions & 11 deletions gen/pb-typescript/src/__generated__/sigstore_common.ts
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 15 additions & 3 deletions protos/sigstore_common.proto
View file
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,21 @@ enum PublicKeyDetails {
PKIX_ED25519 = 7; // See RFC8032
PKIX_ED25519_PH = 8;

// **EXPERIMENTAL**: LMS and LM-OTS variants.
EXPERIMENTAL_LMS_SHA256 = 14;
EXPERIMENTAL_LMOTS_SHA256 = 15;
// LMS and LM-OTS
//
// These keys and signatures may be used by private Sigstore
// deployments, but are not currently supported by the public
// good instance.
//
// USER WARNING: LMS and LM-OTS are both stateful signature schemes.
// Using them correctly requires discretion and careful consideration
// to ensure that individual secret keys are not used more than once.
// In addition, LM-OTS is a single-use scheme, meaning that it
// MUST NOT be used for more than one signature per LM-OTS key.
// If you cannot maintain these invariants, you MUST NOT use these
// schemes.
LMS_SHA256 = 14;
LMOTS_SHA256 = 15;

// Reserved for future additions of public key/signature algorithm types.
reserved 19 to 50;
Expand Down

0 comments on commit 3a1daa1

Please sign in to comment.