Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in documentation of Bundle type #384

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nmiyake
Copy link

@nmiyake nmiyake commented Aug 23, 2024

Summary

Fixes spelling errors in documentation for Bundle type.

Release Note

NONE

Documentation

@woodruffw
Copy link
Member

@nmiyake Thanks for these improvements! Could you run make all locally to propagate these doc fixes to the generated libraries as well?

@nmiyake
Copy link
Author

nmiyake commented Aug 23, 2024

Ah yes, good catch.

Unfortunately, I'm using an Apple silicon machine and it looks like the make script is not fully compatible with arm64 machines: typescript, ruby, and rust all fail with errors of the form InvalidBaseImagePlatform: Base image namely/protoc-all@sha256:33e47b2aece23a282a9f8d03a193c063cdd4b1f60d427b148b3c449b51a3ba3c was pulled with platform "linux/amd64", expected "linux/arm64" for current build (line 1).

I might be able to look into this further later, but blocked at the moment due to this issue.

@loosebazooka
Copy link
Member

Oh maybe we should be using a multiplatform image for protoc

@kommendorkapten
Copy link
Member

I have an old PR to go over this, let's see if I can get that up to speed again. I don't remember the details on how running amd64 on Apple silicon, but it works for me and I didn't perform any configuration. Anyway, we should attempt to run the correct image for the target architecture.

I'll update this PR with the result of running make all.

Signed-off-by: Fredrik Skogman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants