Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signing event: sign/migration-take-two #1348

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Signing event: sign/migration-take-two #1348

merged 2 commits into from
Sep 2, 2024

Conversation

sigstore-bot
Copy link
Member

Processing signing event sign/migration-take-two, please wait.

@sigstore-bot
Copy link
Member Author

Current signing event state

Event sign/migration-take-two (commit 9050b38)

Signing event is successful

Threshold of signatures has been reached: this signing event can be reviewed and merged.

@sigstore-bot sigstore-bot marked this pull request as ready for review September 2, 2024 08:59
@jku

This comment was marked as outdated.

Sign in to view
@jku jku marked this pull request as draft September 2, 2024 09:08
@sigstore-bot
Copy link
Member Author

Current signing event state

Event sign/migration-take-two (commit 2b4bfaa)

✅ root

Role root is verified and signed by 0/3 (5/3) signers (@SantiagoTorres, @joshuagl, @bobcallaway, @mnm678, @dlorenc).

✅ targets

Role targets is verified and signed by 5/3 signers (@dlorenc, @SantiagoTorres, @joshuagl, @bobcallaway, @mnm678).

✅ registry.npmjs.org

Role registry.npmjs.org is verified and signed by 1/1 signers (azurekms://npm-tuf-delegate.vault.azure.net/keys/npm-tuf-delegate-2024-08/e2772c1d01ca400da571096889f1660e).

Signing event is successful

Threshold of signatures has been reached: this signing event can be reviewed and merged.

@sigstore-bot sigstore-bot marked this pull request as ready for review September 2, 2024 09:15
@jku
Reapply "Signing event: sign/migration"
03f9c7e 
We merged sign/migration but had to revert on. After a tuf-on-ci
release we want to
* "merge the same changes again" (aka revert the revert)
* Include the tuf-on-ci upgrade

This reverts the original revert commit
f9b651b.

Signed-off-by: Jussi Kukkonen <[email protected]>
@jku
workflows: Upgrade tuf-on-ci to 0.13.0
29bed78 
This contains a workaround that should make online-sign succeed
(even though the online-url in the metadata is not quite correct)

Signed-off-by: Jussi Kukkonen <[email protected]>
@sigstore-bot
Copy link
Member Author

Current signing event state

Event sign/migration-take-two (commit 29bed78)

✅ root

Role root is verified and signed by 0/3 (5/3) signers (@bobcallaway, @joshuagl, @dlorenc, @mnm678, @SantiagoTorres).

✅ targets

Role targets is verified and signed by 5/3 signers (@mnm678, @SantiagoTorres, @bobcallaway, @joshuagl, @dlorenc).

✅ registry.npmjs.org

Role registry.npmjs.org is verified and signed by 1/1 signers (azurekms://npm-tuf-delegate.vault.azure.net/keys/npm-tuf-delegate-2024-08/e2772c1d01ca400da571096889f1660e).

Signing event is successful

Threshold of signatures has been reached: this signing event can be reviewed and merged.

@jku
Copy link
Member

jku commented Sep 2, 2024 •
edited
Loading

This is a second attempt at #1320:

  • re-introduce changes from the earlier PR (that were reverted), this is literally the result of git revert f9b651b8eb61dfd94a98407853c5a97ab2d01651
  • add a commit to upgrade tuf-on-ci

The first item there should be a 1:1 match to sign/migration changes -- annoyingly it's not very easy to review a "reverted revert".

@jku jku mentioned this pull request Sep 2, 2024
Open
@jku jku merged commit f7e0f4e into main Sep 2, 2024
12 checks passed
@jku jku deleted the sign/migration-take-two branch September 2, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kommendorkapten kommendorkapten kommendorkapten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sigstore-bot @jku @kommendorkapten