Remove old code and metadata #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repository/ is where repository sources used to live, but the canonical locations are now metadata/ and targets/ Note that this also removes the yubikey certificates: * I'm not opposed to storing them but I would like there to be integrated tools that verify them in signing events * Migration made current verification scripts not usable Signed-off-by: Jussi Kukkonen <[email protected]>
* step-* scripts are not needed: tuf-on-ci handles these aspects
* verify and dpop-verify equivalents are partly available:
* the metadata validation side should be handled by tuf-on-ci
reasonably well
* the "verify authentic yubikey" fnctionality is not available
at the moment
Signed-off-by: Jussi Kukkonen <[email protected]>
Let's just trust git to store the signing event / ceremony details. Signed-off-by: Jussi Kukkonen <[email protected]>
* cmd/tuf is replaced by tuf-on-ci * cmd/generate_staging is not needed * cmd/verify equivalent is not available currently: We can bring something like it back but current code is not usable Signed-off-by: Jussi Kukkonen <[email protected]>
As described in sigstore#1362 we are removing the key authenticity validation for now. It may come back later. Signed-off-by: Jussi Kukkonen <[email protected]>
Signed-off-by: Jussi Kukkonen <[email protected]>
There is no code to use this data anymore: we may still have to maintain these fields in the metadata for legacy reasons but this has to be done manually -- this is described in maintainer manual. Signed-off-by: Jussi Kukkonen <[email protected]>
|
WRT the go package: Based on GitHub dependency tracking there are no dependents that would break: sigstore-probers is listed as a user but that is AFAICT historical: current sigstore-probers does not use root-signing go code |
|
Good call on the probers, are they in a separate repository? |
sigstore/sigstore-probers: it used to use some root-signing verify calls but currently the only TUF related thing left should be calls to |
haydentherapper
approved these changes
Sep 5, 2024
| extraargs="--out-format github-actions"; \ | ||
| fi; \ | ||
| $(GOBIN)/golangci-lint run -c .golangci.yml ./... $$extraargs | ||
|
|
||
| yamllint: ## Runs the yamllint linter. |
There was a problem hiding this comment.
In a later PR, probably worth removing the Makefile entirely and moving this block into .github/workflows/lint.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1356: Remove legacy code and metadata.
It's massive PR, apologies. I can split it if requested but a lot of these parts depend on each other so the split will be mostly aesthetic.
metadata/: it's better to remove the legacyrepository/ASAP so people do not get confused