-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to parse pubkey from Fulcio cert #153
base: main
Are you sure you want to change the base?
Conversation
2851973
to
75a8bef
Compare
Signed-off-by: Lily Sturmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm against that, because this would cause openssl to become a runtime dependency, making impossible for consumers of this library to build their libraries/binaries as pure Rust.
If you want I can help with the rewrite of this code using the crates that are already being consumed.
BTW: currently openssl
is a development dependency because it's used to create x509 certificates inside of the unit tests. This code could be rewritten using picky-rs
, but I didn't consider that worth the effort.
I had not noticed that, incorrectly read it as a version bump. Agree with @flavio here, a lot of minimal images ship without openssl. |
Sure, I can rewrite it with one of the existing crates probably after this week... stay tuned! |
Thanks a lot @lkatalin for understanding the issue |
Signed-off-by: Lily Sturmann [email protected]