Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to parse pubkey from Fulcio cert #153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lkatalin
Copy link
Contributor

Signed-off-by: Lily Sturmann [email protected]

@lkatalin lkatalin marked this pull request as draft October 24, 2022 15:44
@lkatalin lkatalin force-pushed the fulcio_parse_openssl branch 2 times, most recently from 2851973 to 75a8bef Compare October 24, 2022 15:49
Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@lkatalin lkatalin marked this pull request as ready for review October 24, 2022 15:54
@lkatalin lkatalin marked this pull request as draft October 24, 2022 15:57
@lkatalin lkatalin marked this pull request as ready for review October 24, 2022 15:58
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm against that, because this would cause openssl to become a runtime dependency, making impossible for consumers of this library to build their libraries/binaries as pure Rust.

If you want I can help with the rewrite of this code using the crates that are already being consumed.

BTW: currently openssl is a development dependency because it's used to create x509 certificates inside of the unit tests. This code could be rewritten using picky-rs, but I didn't consider that worth the effort.

@lukehinds
Copy link
Member

I had not noticed that, incorrectly read it as a version bump. Agree with @flavio here, a lot of minimal images ship without openssl.

@lkatalin
Copy link
Contributor Author

Sure, I can rewrite it with one of the existing crates probably after this week... stay tuned!

@flavio
Copy link
Member

flavio commented Oct 25, 2022

Thanks a lot @lkatalin for understanding the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants