making values array empty in each scrape

siimon · May 31, 2024 · 49da0d9 · 49da0d9
1 parent 7879114
commit 49da0d9
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/lib/cluster.js b/lib/cluster.js
@@ -120,7 +120,6 @@ class AggregatorRegistry extends Registry {
 
 		// Aggregate gathered metrics.
 		metricsByName.forEach(metrics => {
-			metrics.workerSize = metricsArr.length;
 			const aggregatorName = metrics[0].aggregator;
 			const aggregatorFn = aggregators[aggregatorName];
 			if (typeof aggregatorFn !== 'function') {

diff --git a/lib/metricAggregators.js b/lib/metricAggregators.js
@@ -28,11 +28,7 @@ function AggregatorFactory(aggregatorFn) {
 				if (!valuesArray) {
 					byLabels.set(value.hash, [value]);
 				} else {
-					if (valuesArray.length < metrics.workerSize) {
-						valuesArray.push(value);
-					} else {
-						byLabels.set(value.hash, [value]);
-					}
+					valuesArray.push(value);
 				}
 			});
 		});
@@ -48,6 +44,7 @@ function AggregatorFactory(aggregatorFn) {
 			}
 			// NB: Timestamps are omitted.
 			result.values.push(valObj);
+			values.length = 0;
 		});
 		return result;
 	};

diff --git a/test/aggregatorsTest.js b/test/aggregatorsTest.js
@@ -23,8 +23,6 @@ describe('aggregators', () => {
 		},
 	];
 
-	metrics.workerSize = 2;
-
 	describe('sum', () => {
 		it('properly sums values', () => {
 			const result = aggregators.sum(metrics);
@@ -119,7 +117,6 @@ describe('aggregators', () => {
 					values: [{ labels: [], value: 5, metricName: 'def', hash: 'h2' }],
 				},
 			];
-			metrics2.workerSize = 2;
 			const result = aggregators.sum(metrics2);
 			expect(result.values).toEqual([
 				{ value: 4, labels: [], metricName: 'abc' },