Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup warning outputs #1858

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Cleanup warning outputs #1858

merged 3 commits into from
Sep 5, 2023

Conversation

alerque
Copy link
Member

@alerque alerque commented Sep 4, 2023

Fixes #1857

…ace info

Sometimes it is helpful to know where a warning message got thrown. For
a few cases of just wanting to tell something to the user it might not
be relevant at all, and the "at ..." location trace is distracting and
confusing.
@alerque alerque added this to the v0.14.12 milestone Sep 4, 2023
@alerque alerque added the bug Software bug issue label Sep 4, 2023
@alerque alerque merged commit 848920b into sile-typesetter:master Sep 5, 2023
10 of 14 checks passed
@alerque alerque deleted the toc-msg branch September 5, 2023 00:03
@Omikhleia
Copy link
Member

Merged but causing a luacheck issue...

@alerque
Copy link
Member Author

alerque commented Sep 11, 2023

My bad, thanks for noticing. The Lua 5.1 test failing for unrelated reasons in CI is throwing off my local workflows and I got sloppy. I'll probably just fix this in master without a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"table of contents has changed" always emitted
2 participants