Touchup Mac builds and Nix flake #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
added
todo
tooling
doronbehar
reviewed
Dec 20, 2023
|
Sounds good to me. Great!
…On 20 December 2023 22:25:49 GMT+02:00, Caleb Maclennan ***@***.***> wrote:
@alerque commented on this pull request.
> @@ -118,8 +118,6 @@ in stdenv.mkDerivation (finalAttrs: {
postPatch = ''
patchShebangs build-aux/*.sh build-aux/git-version-gen
- '' + lib.optionalString stdenv.isDarwin ''
- sed -i -e ***@***.*** AppKit;|#import <AppKit/AppKit.h>|' src/macfonts.m
'';
NIX_LDFLAGS = lib.optionalString stdenv.isDarwin "-framework AppKit";
Thank for the options. I'll look into them, some now some later.
For the moment I think we'll move ahead with the bits I'm sure about, then when v0.15.0 actually drops and we update the official Nix pkgs repo with the stable release we can test whether than is needed or not. If not we can then remove it from the Flake too.
--
Reply to this email directly or view it on GitHub:
#1941 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1879