Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display math numbering #2020

Merged

Conversation

Omikhleia
Copy link
Member

Something is better than nothing -- This is a curated re-implementation of @leorosa 's #1821 taking into account all comments there.

  • \math[mode=display]{...} works as before
  • \math[mode=display, numbered=true]{...} uses counter "equation" for numbering
  • \math[mode=display, counter=id]{...} uses counter id for numbering
  • \math[mode=display, number=xxx]{...} uses direct value xxx as number, would the use want any unusual equation "naming" which can't be achieved by a regular counter

Two test files are also included.
(While the package code does not depend on it, tests uses the blockquote environment for checking margin stkips are honored, hence the 0.15 milestone label).

STILL TO DO: Generate the text expectations (my fresh install of SILE using the nix flake for the "develop" branch doesn't have the appropriate font versions, and I don't want to alter the host's fonts)

@Omikhleia Omikhleia added enhancement Software improvement or feature request modules:packages Issue relates to core or 3rd party packages labels May 7, 2024
@Omikhleia Omikhleia added this to the v0.15.0 milestone May 7, 2024
@Omikhleia Omikhleia self-assigned this May 7, 2024
@Omikhleia Omikhleia requested review from a team and alerque as code owners May 7, 2024 07:43
@Omikhleia Omikhleia mentioned this pull request May 7, 2024
@Omikhleia
Copy link
Member Author

@leorosa Of course you are credited viaCo-authored-by in the main commit.

@leorosa
Copy link
Contributor

leorosa commented May 10, 2024

@leorosa Of course you are credited viaCo-authored-by in the main commit.

Don't worry about that. I'm really happy to see this (needed) feature in sile!
And sorry for not being able to progress with my PR: more than the 'credit', it would be useful to me, to learn more about git and tests. Maybe next time :)

@alerque alerque force-pushed the feat-display-math-numbering branch from 66317dc to 1bf0140 Compare May 28, 2024 20:06
@alerque
Copy link
Member

alerque commented May 28, 2024

I just pushed test expectations.

@alerque alerque merged commit 1f3c218 into sile-typesetter:develop May 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Software improvement or feature request modules:packages Issue relates to core or 3rd party packages
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants