Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(math): Support MathML mtext and ms elements #2140

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

Omikhleia
Copy link
Member

@Omikhleia Omikhleia commented Oct 17, 2024

Ticking one box in #2138

I am on a quest, sort of...

So let's derive the Quadratic Formula.

image

@Omikhleia Omikhleia added the enhancement Software improvement or feature request label Oct 17, 2024
@Omikhleia Omikhleia requested a review from a team as a code owner October 17, 2024 09:59
@Omikhleia Omikhleia self-assigned this Oct 17, 2024
@Omikhleia Omikhleia added this to the v0.15.6 milestone Oct 17, 2024
Similar to the `\text` command in amsmath, but does not support internal
embedding of math equations. Yet it covers the usual need for some bits
of regular text inside math formula.
@OlivierNicole
Copy link
Member

This looks like a good working first step. Note that one day we probably want to be able to use SILE commands in \text, just like arbitrary TeX formatting can be applied inside a \text{...}

@Omikhleia
Copy link
Member Author

Note that one day we probably want to be able to use SILE commands in \text, just like arbitrary TeX formatting can be applied inside a \text{...}

But I'd advocate against it, as far as I have a word to say. It's not a "common" denominator for any real use case.

@Omikhleia
Copy link
Member Author

Omikhleia commented Oct 18, 2024

But I'd advocate against it, as far as I have a word to say. It's not a "common" denominator for any real use case.

"Note that one day we probably want to be able to use SILE commands"... Really? Folks, please be much more precise, do you mean SIL in its TeX-like syntax? (as \em and that sort of stuff?). Do you imply there's a real added value in general for this to be true? Do you have, I dunno, a real book project where you desperately need such a thing?

Had you said: "one day we probably want to be able to use Markdown, Djot or other markup in \text", I'd would have raised an eyebrow with interest.

How long does it take for you to understand that SIL is a dead end?

@Omikhleia
Copy link
Member Author

BUT let's go back on topic; there's a PR here, does it pass the bar? Something is better, sometimes, than an idealized nothingness.

@Omikhleia Omikhleia mentioned this pull request Oct 19, 2024
@alerque
Copy link
Member

alerque commented Oct 29, 2024

Hey guys can we take the rhetoric down a notch or two please? I should have caught this earlier but I've spent most of a couple weeks waiting in a hospital and haven't had the energy. This is an entirely volunteer project and interested parties are going to have different ideas and backgrounds. It's okay to disagree, but the last half dozen issues I've looked at today have a bit too much snark. I appreciate the contributions for sure and it's okay to think we're doing some things wrong, but lets take it easy.

Trying to ignore the tone now and address a little point:

How long does it take for you to understand that SIL is a dead end?

Says who? You don't have to use it or like it, but given how much easier it is to read and write manually than XML I don't see it going anywhere. Also it is (or should be) 100% just % syntactic sugar over a semantic document that could just as well have been XML. It is easy to parse and very overhead to maintain, so it is not going anywhere.

That being said I don't see it as any different from any other input format, we should have 100% first class coverage for either XML or SIL (and potentially others in the future), the SIL syntax sugar is not some magic special "this is the SILE way" that gets special treatment.

"Note that one day we probably want to be able to use SILE commands"... Really? Folks, please be much more precise, do you mean SIL in its TeX-like syntax?

I read this as SILE commands, probably matching whatever syntax flavor the parent document is using (XML-ish or TeX-ish or whatever other input module is being used. And yes I agree that text content inside an equation should support the typesetting features of the typesetter, not just plain text. There is precedent for this in every other Math layout system I've seen (including GUI ones used in desktop publishing, for better or worse).

That doesn't mean it has to be in this PR, just saying I'd be open for contributions in that direction.

@alerque alerque merged commit 0cd24ab into sile-typesetter:master Oct 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Software improvement or feature request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants