add stream_upload_source #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oah8
force-pushed
the
feat_stream_upload_tempmaterials
branch
2 times, most recently
from
0ba62d8
to
b47cbba
Compare
houseme
reviewed
Jul 24, 2024
houseme
reviewed
Jul 24, 2024
util/http.go
Outdated
| @@ -8,13 +8,13 @@ import ( | |||
| "encoding/pem" | |||
| "encoding/xml" | |||
| "fmt" | |||
| "golang.org/x/crypto/pkcs12" | |||
There was a problem hiding this comment.
这一行 import 放到17行，path包放在os包下面
houseme
reviewed
Jul 24, 2024
PublicPwd
reviewed
Jul 24, 2024
work/material/media.go
Outdated
| @@ -59,16 +58,21 @@ func (r *Client) UploadImg(filename string) (*UploadImgResponse, error) { | |||
| // UploadTempFile 上传临时素材 | |||
| // @see https://developer.work.weixin.qq.com/document/path/90253 | |||
| // @mediaType 媒体文件类型，分别有图片（image）、语音（voice）、视频（video），普通文件（file） | |||
| func (r *Client) UploadTempFile(filename string, mediaType string) (*UploadTempFileResponse, error) { | |||
| // 临时素材一般都是存储在oss上的，可以直接传递url | |||
| func (r *Client) UploadTempFile(url string, mediaType string) (*UploadTempFileResponse, error) { | |||
There was a problem hiding this comment.
这个方法参数含义从本地文件变成远程资源，是不是另起一个方法会好一些？
There was a problem hiding this comment.
已改为UploadRemoteTempFile
work/material/media.go
Outdated
| var ( | ||
| accessToken string | ||
| err error | ||
| ) | ||
| if accessToken, err = r.GetAccessToken(); err != nil { | ||
| return nil, err | ||
| } | ||
| filename, byteData, err := util.GetFileSourceByURL(url) |
There was a problem hiding this comment.
这块是不是可以优化下，比如：
res, _ := http.Get()
defer res.body.Close()
somethingElse := res.Header.Get()
util.PostFileFromReader(_, _, _, res.body)There was a problem hiding this comment.
这个util里的PostFileFromReader函数好像复用不了 😭
好 |
oah8
force-pushed
the
feat_stream_upload_tempmaterials
branch
from
b47cbba
to
26a6d7d
Compare
你好，要是被合并需要满足啥条件 |
houseme
reviewed
Aug 5, 2024
work/material/media.go
Outdated
| // @see https://developer.work.weixin.qq.com/document/path/90253 | ||
| // @mediaType 媒体文件类型，分别有图片（image）、语音（voice）、视频（video），普通文件（file） | ||
| func (r *Client) UploadTempFile(filename string, mediaType string) (*UploadTempFileResponse, error) { | ||
| // 临时素材一般都是存储在oss上的，可以直接传递url | ||
| func (r *Client) UploadRemoteTempFile(url string, mediaType string) (*UploadTempFileResponse, error) { |
There was a problem hiding this comment.
这个方法名字不要改动了，之内改掉会影响之前版本的升级
oah8
force-pushed
the
feat_stream_upload_tempmaterials
branch
from
26a6d7d
to
e55faeb
Compare
houseme
approved these changes
Aug 6, 2024
houseme
requested review from
PublicPwd and
silenceper
and removed request for
PublicPwd
PublicPwd
reviewed
Aug 7, 2024
officialaccount/material/material.go
Outdated
| @@ -163,7 +164,7 @@ type resAddMaterial struct { | |||
| } | |||
|
|
|||
| // AddMaterialFromReader 上传永久性素材（处理视频需要单独上传），从 io.Reader 中读取 | |||
| func (material *Material) AddMaterialFromReader(mediaType MediaType, filename string, reader io.Reader) (mediaID string, url string, err error) { | |||
| func (material *Material) AddMaterialFromReader(mediaType MediaType, directory string, reader io.Reader) (mediaID string, url string, err error) { | |||
There was a problem hiding this comment.
这里 filename 直接改成 directory 似乎没有意义，如果为了素材库中展示的文件名，或许可以改成这样？
AddMaterialFromReader(mediaType MediaType, filePath, fileName string, reader io.Reader)
work/material/media.go
Outdated
| @@ -59,16 +59,21 @@ func (r *Client) UploadImg(filename string) (*UploadImgResponse, error) { | |||
| // UploadTempFile 上传临时素材 | |||
| // @see https://developer.work.weixin.qq.com/document/path/90253 | |||
| // @mediaType 媒体文件类型，分别有图片（image）、语音（voice）、视频（video），普通文件（file） | |||
| func (r *Client) UploadTempFile(filename string, mediaType string) (*UploadTempFileResponse, error) { | |||
| // 临时素材一般都是存储在oss上的，可以直接传递url | |||
| func (r *Client) UploadTempFile(url string, mediaType string) (*UploadTempFileResponse, error) { | |||
util/http.go
Outdated
| err = fmt.Errorf("get resp error: %v", err) | ||
| return | ||
| } | ||
| byteData, err = io.ReadAll(resp.Body) |
There was a problem hiding this comment.
我的想法是 URL 可以在 SDK 外实现，比如：
const ossURL = ""
res, _ := http.Get(ossURL)
defer res.Body.Close()
officialaccount.Client.AddMaterialFromReader(_, _, res.Body)或是 SDK 内部下载 URL 文件的话，就改成 io.Copy() 实现
oah8
force-pushed
the
feat_stream_upload_tempmaterials
branch
from
e55faeb
to
ed149ad
Compare
oah8
force-pushed
the
feat_stream_upload_tempmaterials
branch
from
ed149ad
to
a8e6bce
Compare
|
已更改 😭 |
silenceper
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.