feat: upload file without formdata #495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silkimen
reviewed
Feb 20, 2023
silkimen
added a commit
that referenced
this pull request
Feb 20, 2023
deenel
added a commit
to MobisysGmbH/cordova-plugin-advanced-http
that referenced
this pull request
Feb 22, 2024
* feat: upload file without formdata * fix: handle 'missing' options * test: implement tests for silkimen#495 * chore: some cleanup * add fork version, add transmitfileas to readme * bump version --------- Co-authored-by: Tobias Becht <[email protected]> Co-authored-by: Sefa Ilkimen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to support native file uploads without the use of form-data. Therefore it was necessary to supply more information to the "uploadFiles" command and create a new way to upload those raw files.
ToDo
Details
There is a new option 'transmitFileAs' which currently only supports
"BINARY",NULL,undefinedorany string except "binary". The default behavior is "FORMDATA". There is no need to change existing code.If you want to use this new feature, you can use
http.sendRequest({ method: 'upload', fileName: '<yourfile>', transmitFileAs: 'BINARY', url: '<your url>' }).