Renamed project to SIL.Windows.Forms.Archiving #1317

josephmyers · 2024-04-25T08:27:33Z

This change is

To align with all other WinForms projects

tombogle

Reviewed 1 of 68 files at r1, all commit messages.
Reviewable status: 1 of 68 files reviewed, 1 unresolved discussion (waiting on @josephmyers)

Palaso.sln line 30 at r1 (raw file):

Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SIL.Windows.Forms.Archiving", "SIL.Windows.Forms.Archiving\SIL.Windows.Forms.Archiving.csproj", "{BCE1F124-5479-4B23-90B1-B7A4EBE44FA3}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SIL.Windows.Forms.Archiving.Tests", "SIL.Windows.Forms.Archiving.Tests\SIL.Windows.Forms.Archiving.Tests.csproj", "{892C7F20-FBBB-4AB3-BAC2-E40A135567B6}"

Now I'm wondering if we should actually be trying to split this stuff into Forms vs. non-Forms DLLs. None of the unit tests depend on WinForms, so all the classes they are testing could be in a non-Forms dependent DLL. I'm not sure if they do anything useful enough on their own to warrant this though.

tombogle · 2024-04-25T12:51:49Z

Palaso.sln line 30 at r1 (raw file):

Previously, tombogle (Tom Bogle) wrote…

Now I'm wondering if we should actually be trying to split this stuff into Forms vs. non-Forms DLLs. None of the unit tests depend on WinForms, so all the classes they are testing could be in a non-Forms dependent DLL. I'm not sure if they do anything useful enough on their own to warrant this though.

Looking at the code, the ArchivingDlg classes (abstract base and two concrete implementations) are the only things that really need to depend on WinForms. The models do, but only minimally and in a way they really shouldn't. If we were to fix those design issues, then those models could be used to back a non WinForms implementation.

megahirt

The changelog should not be included in the find/replace and there should also be a line for this rename in the changelog. Thanks!

CHANGELOG.md

+semver:major

megahirt

Looks good, thanks @josephmyers

megahirt

Reviewed 67 of 68 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @josephmyers)

josephmyers · 2024-05-09T05:09:22Z

@tombogle, any chance we'll see progress here this week or next?

tombogle · 2024-05-13T13:59:54Z

Not sure when I'll be able to get to this.

josephmyers · 2024-05-20T08:31:28Z

I discovered today that SIL.Media is a WinForms project. So a bit more to come on this

megahirt · 2024-05-20T13:19:33Z

I discovered today that SIL.Media is a WinForms project. So a bit more to come on this

@josephmyers we can rename SIL.Media in a separate PR.

megahirt

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @josephmyers)

megahirt

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @josephmyers and @tombogle)

Palaso.sln line 30 at r1 (raw file):

Previously, tombogle (Tom Bogle) wrote…

Looking at the code, the ArchivingDlg classes (abstract base and two concrete implementations) are the only things that really need to depend on WinForms. The models do, but only minimally and in a way they really shouldn't. If we were to fix those design issues, then those models could be used to back a non WinForms implementation.

@tombogle how about we just leave this PR as a simple rename and if you'd like to circle back on a refactor that you can do that in a separate PR? I'd like to get this merged.

josephmyers · 2024-06-06T05:58:22Z

I discovered today that SIL.Media is a WinForms project. So a bit more to come on this

@josephmyers we can rename SIL.Media in a separate PR.

#1325

Stale

tombogle · 2024-07-16T19:04:44Z

I'm doing some fixing in this area currently, so this might actually be a good time for me to try to break it into two parts. Give me a couple days, and if I can't, then we'll go ahead and merge as is.

This helps clarify some unexpected behavior in SayMore tests.

# Conflicts: # CHANGELOG.md

…SIL.Core Added optional parameter to OlacSystem.GetRoles to allow caller to provide its own XML

…ndows.Forms.Archiving Included significant refactoring and replacing clunky cancellation of background process (which required calls to Application.DoEvents) with a proper async approach.

# Conflicts: # SIL.Media.Tests/SIL.Media.Tests.csproj

github-actions · 2024-08-01T14:10:56Z

LibPalaso Tests

17 files ±0 17 suites ±0 9m 34s ⏱️ - 2m 50s
4 890 tests +6 4 659 ✅ +6 231 💤 ±0 0 ❌ ±0
4 909 runs +6 4 665 ✅ +6 244 💤 ±0 0 ❌ ±0

Results for commit 67b1ecd. ± Comparison against base commit d85edaa.

This pull request removes 54 and adds 60 tests. Note that renamed tests count towards both.

SIL.Archiving.Tests.RampArchivingDlgViewModelTests ‑ GetMode_FwbackupFileWithMultipleTypesInList_ReturnsCorrectMetsList
SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_AllSame_ReturnsTrue
SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_DatesDifferent_ReturnsFalse
SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_LicensesDifferent_ReturnsFalse
SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_NamesDifferent_ReturnsFalse
SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_NotesDifferent_ReturnsFalse
SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_OtherIsNull_ReturnsFalse
SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_RolesDifferent_ReturnsFalse
SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ Clone_ReturnsDifferentNonNullObject
SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ Clone_ReturnsSameContent
…

SIL.Archiving.Tests.ArchivingLanguageTests ‑ Compare_DifferentCodeOrLanguageName_ReturnsNonZero("eng","English","frg","Froggish")
SIL.Archiving.Tests.ArchivingLanguageTests ‑ Compare_DifferentCodeOrLanguageName_ReturnsNonZero("som","Some Language","unk","Some Language")
SIL.Archiving.Tests.ArchivingLanguageTests ‑ Compare_DifferentCodeOrLanguageName_ReturnsNonZero("zzz","Zyzzyvian","zzz","Scrabbilian")
SIL.Archiving.Tests.ArchivingLanguageTests ‑ Compare_SameCodeAndLanguageName_ReturnsZero
SIL.Archiving.Tests.LanguageListTests ‑ FindByEnglishName_ExistingLanguage_GetsExpectedNameCodeAndId("English","eng")
SIL.Archiving.Tests.LanguageListTests ‑ FindByISO3Code_ExistingLanguageWithNoOtherName_GetsExpectedNameCodeAndId("eng","English")
SIL.Archiving.Tests.RampArchivingDlgViewModelTests ‑ GetMode_FwBackupFileWithMultipleTypesInList_ReturnsCorrectMetsList
SIL.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_AllSame_ReturnsTrue
SIL.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_DatesDifferent_ReturnsFalse
SIL.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_LicensesDifferent_ReturnsFalse
…

♻️ This comment has been updated with latest results.

…ves. Improved documentation and did code cleanup for some of the IMDI stuff. Closed some loopholes to make it easier for clients to create valid packages

tombogle · 2024-08-05T21:29:21Z

I have completed my work on splitting this into two DLLs. Ready for review.

hahn-kev

there's some issues with how async works at the moment, but it looks good otherwise.

ArchivingTestApp/ArchivingTestApp.csproj

SIL.Archiving.Tests/IMDIArchivingDlgViewModelTests.cs

SIL.Archiving/IMDI/IMDIArchivingDlgViewModel.cs

SIL.Archiving/RampArchivingDlgViewModel.cs

SIL.Core/ClearShare/OlacSystem.cs

tombogle · 2024-08-06T14:19:39Z

Palaso.sln line 30 at r1 (raw file):

Previously, megahirt (Christopher Hirt) wrote…

@tombogle how about we just leave this PR as a simple rename and if you'd like to circle back on a refactor that you can do that in a separate PR? I'd like to get this merged.

No longer relevant

tombogle · 2024-08-06T14:19:58Z

What sort of issues?

tombogle · 2024-08-06T14:21:52Z

Never mind. I see there are some github comments that Reviewable knows nothing about.

… TargetFrameworks property

Changed OlacSystem.GetRoles to report a non-fatal exception if the custom XML file cannot be loaded. Removed ArchivingPackage and AddSession from ArchivingDlgViewModel and RampArchivingDlgViewModel

hahn-kev

Looks good, I agree _imdiData.CreateIMDIPackage() in IMDI view model should also be awaited, nice catch.

SIL.Archiving/IMDI/IMDIArchivingDlgViewModel.cs

hahn-kev

Looks good to me. I'll leave it up to you @tombogle how you handle the conversation on IMDIArchivingDlgViewModel.cs

hahn-kev

Reviewed 2 of 73 files at r1, 102 of 119 files at r3, 7 of 22 files at r4, 5 of 6 files at r5, 4 of 8 files at r6, 1 of 1 files at r7, 2 of 2 files at r8, 4 of 4 files at r11, 2 of 2 files at r12, all commit messages.
Reviewable status: all files reviewed, 11 unresolved discussions (waiting on @josephmyers and @megahirt)

tombogle

Reviewed all commit messages.
Reviewable status: all files reviewed, 11 unresolved discussions (waiting on @hahn-kev, @josephmyers, and @megahirt)

SIL.Archiving/IMDI/IMDIArchivingDlgViewModel.cs line 189 at r7 (raw file):

Previously, tombogle (Tom Bogle) wrote…

In reality, most of this stuff is pretty fast on modern hardware, so unless you have a lot of files or some really big files, it's probably going to finish before you've had much of a chance to think about canceling.

I went ahead and made CreateIMDIPackage take a cancellation token and return Task, so now it checks the cancellation state before each IO call. Technically it's still synchronous

tombogle

Reviewable status: all files reviewed, 10 unresolved discussions (waiting on @hahn-kev and @josephmyers)

Renamed project to SIL.Windows.Forms.Archiving

6f47b22

To align with all other WinForms projects

josephmyers marked this pull request as ready for review April 25, 2024 08:49

tombogle previously requested changes Apr 25, 2024

View reviewed changes

megahirt requested changes Apr 26, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Reverted rename in changelog and added an entry

dd8bfd9

+semver:major

megahirt approved these changes Apr 26, 2024

View reviewed changes

josephmyers self-assigned this May 10, 2024

josephmyers linked an issue May 20, 2024 that may be closed by this pull request

Upgrade to .NET8 #1320

Open

7 tasks

megahirt approved these changes May 20, 2024

View reviewed changes

tombogle added 3 commits July 16, 2024 15:12

Improved/added some comments related to LanguageList and its tests

39927bf

This helps clarify some unexpected behavior in SayMore tests.

Merge branch 'master' into sil.windows.forms.archiving

bad282b

# Conflicts: # CHANGELOG.md

+semver:major Split ClearShare code, moving non-Winforms portions to …

b3b018a

…SIL.Core Added optional parameter to OlacSystem.GetRoles to allow caller to provide its own XML

tombogle force-pushed the sil.windows.forms.archiving branch from 155148d to b3b018a Compare July 17, 2024 15:59

tombogle added 2 commits July 31, 2024 23:20

+semver:major Split SIL.Archiving, moving Winforms portions to SIL.Wi…

0dfeebe

…ndows.Forms.Archiving Included significant refactoring and replacing clunky cancellation of background process (which required calls to Application.DoEvents) with a proper async approach.

Merge branch 'master' into sil.windows.forms.archiving

81cd9ac

# Conflicts: # SIL.Media.Tests/SIL.Media.Tests.csproj

tombogle added 4 commits August 1, 2024 15:56

Merge branch 'master' into sil.windows.forms.archiving

23cd3e0

Merge branch 'master' into sil.windows.forms.archiving

414f7ef

Added binding redirects to fix failing unit tests

f0310fb

[WIP] Started adding a test app for the archiving stuff

defcf71

Got archiving test app to work correctly for both RAMP and IMDI archi…

445b557

…ves. Improved documentation and did code cleanup for some of the IMDI stuff. Closed some loopholes to make it easier for clients to create valid packages

tombogle closed this Aug 5, 2024

tombogle reopened this Aug 5, 2024

hahn-kev requested changes Aug 6, 2024

View reviewed changes

tombogle added 3 commits August 6, 2024 10:33

Moved ArchivingTestApp into the TestApps folder and removed redundant…

62d0165

… TargetFrameworks property

Improved Archiving to make async stuff and cancelling work better.

14393d5

Changed OlacSystem.GetRoles to report a non-fatal exception if the custom XML file cannot be loaded. Removed ArchivingPackage and AddSession from ArchivingDlgViewModel and RampArchivingDlgViewModel

Changed from TargetFramework to TargetFrameworks in csproj

921ce3c

hahn-kev reviewed Aug 7, 2024

View reviewed changes

SIL.Archiving/IMDI/IMDIArchivingDlgViewModel.cs Outdated Show resolved Hide resolved

Refactoring (in response to code review) to simplify SetFilesToArchive

7f5b100

hahn-kev approved these changes Aug 14, 2024

View reviewed changes

Changed creation of IMDIPackages to be asynchronous

8874e89

tombogle force-pushed the sil.windows.forms.archiving branch from 995b464 to 8874e89 Compare August 14, 2024 15:13

tombogle added 2 commits August 14, 2024 16:06

Trying to get Appveyor build to work

40b8925

Fixed naming error in unit test

67b1ecd

josephmyers removed a link to an issue Aug 15, 2024

Upgrade to .NET8 #1320

Open

7 tasks

hahn-kev approved these changes Aug 15, 2024

View reviewed changes

tombogle reviewed Aug 15, 2024

View reviewed changes

tombogle approved these changes Aug 15, 2024

View reviewed changes

tombogle enabled auto-merge August 15, 2024 12:37

tombogle merged commit fad4b64 into master Aug 15, 2024
3 of 4 checks passed

tombogle deleted the sil.windows.forms.archiving branch August 15, 2024 12:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Renamed project to SIL.Windows.Forms.Archiving #1317

Renamed project to SIL.Windows.Forms.Archiving #1317

josephmyers commented Apr 25, 2024 •

edited by andrew-polk

Loading

tombogle left a comment

tombogle commented Apr 25, 2024

megahirt left a comment

megahirt left a comment

megahirt left a comment

josephmyers commented May 9, 2024

tombogle commented May 13, 2024

josephmyers commented May 20, 2024

megahirt commented May 20, 2024

megahirt left a comment

megahirt left a comment

josephmyers commented Jun 6, 2024

tombogle commented Jul 16, 2024

github-actions bot commented Aug 1, 2024 •

edited

Loading

tombogle commented Aug 5, 2024

hahn-kev left a comment

tombogle commented Aug 6, 2024

tombogle commented Aug 6, 2024

tombogle commented Aug 6, 2024

hahn-kev left a comment

hahn-kev left a comment

hahn-kev left a comment

tombogle left a comment

tombogle left a comment

Renamed project to SIL.Windows.Forms.Archiving #1317

Renamed project to SIL.Windows.Forms.Archiving #1317

Conversation

josephmyers commented Apr 25, 2024 • edited by andrew-polk Loading

tombogle left a comment

Choose a reason for hiding this comment

tombogle commented Apr 25, 2024

megahirt left a comment

Choose a reason for hiding this comment

megahirt left a comment

Choose a reason for hiding this comment

megahirt left a comment

Choose a reason for hiding this comment

josephmyers commented May 9, 2024

tombogle commented May 13, 2024

josephmyers commented May 20, 2024

megahirt commented May 20, 2024

megahirt left a comment

Choose a reason for hiding this comment

megahirt left a comment

Choose a reason for hiding this comment

josephmyers commented Jun 6, 2024

tombogle commented Jul 16, 2024

github-actions bot commented Aug 1, 2024 • edited Loading

LibPalaso Tests

tombogle commented Aug 5, 2024

hahn-kev left a comment

Choose a reason for hiding this comment

tombogle commented Aug 6, 2024

tombogle commented Aug 6, 2024

tombogle commented Aug 6, 2024

hahn-kev left a comment

Choose a reason for hiding this comment

hahn-kev left a comment

Choose a reason for hiding this comment

hahn-kev left a comment

Choose a reason for hiding this comment

tombogle left a comment

Choose a reason for hiding this comment

tombogle left a comment

Choose a reason for hiding this comment

josephmyers commented Apr 25, 2024 •

edited by andrew-polk

Loading

github-actions bot commented Aug 1, 2024 •

edited

Loading