Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added netstandard2.0 to SIL.DictionaryServices #1323

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Added netstandard2.0 to SIL.DictionaryServices #1323

merged 1 commit into from
Jun 7, 2024

Conversation

josephmyers
Copy link
Collaborator

@josephmyers josephmyers commented May 20, 2024 •
edited by andrew-polk
Loading

This change is Reviewable

@josephmyers josephmyers linked an issue May 20, 2024 that may be closed by this pull request
Upgrade to .NET8 #1320
Open
7 tasks
megahirt
megahirt approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SIL.Core.Desktop/SIL.Core.Desktop.csproj Show resolved Hide resolved
@josephmyers
Added netstandard2.0 to SIL.DictionaryServices
fbf831d 
And fixed some build warnings from SIL.Core.Desktop
@josephmyers josephmyers merged commit 310d956 into master Jun 7, 2024
3 checks passed
@josephmyers josephmyers deleted the nonwinforms-netstandard branch June 7, 2024 04:19
@josephmyers josephmyers removed a link to an issue Aug 15, 2024
Upgrade to .NET8 #1320
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megahirt megahirt megahirt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephmyers @megahirt