SF-3206 Display Cancel Draft dialog regardless of build state #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebuss
added
the
will require testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3021 +/- ##
==========================================
- Coverage 82.65% 82.65% -0.01%
==========================================
Files 553 553
Lines 32011 32010 -1
Branches 5187 5186 -1
==========================================
- Hits 26459 26458 -1
Misses 4783 4783
Partials 769 769 ☔ View full report in Codecov by Sentry. |
kylebuss
force-pushed
the
improvement/sf-3206-always-display-draft-cancel-dialog
branch
from
1926a43 to
842ff41
Compare
pmachapman
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kylebuss)
pmachapman
added
ready to test
and removed
will require testing
kylebuss
commented
Feb 18, 2025
There was a problem hiding this comment.
Done.
Reviewable status:
RaymondLuong3
force-pushed
the
improvement/sf-3206-always-display-draft-cancel-dialog
branch
from
842ff41 to
eb97977
Compare
RaymondLuong3
deleted the
improvement/sf-3206-always-display-draft-cancel-dialog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the existing Cancel Draft dialog to always display when a user selects to cancel a draft. This is intended to reduce incidental cancelation of drafts because of different draft build states allowing cancellation without displaying the prompt.
This change is