Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workload pvcs #72

Merged
merged 19 commits into from
Feb 4, 2025
Merged

Workload pvcs #72

merged 19 commits into from
Feb 4, 2025

Conversation

salexo
Copy link
Contributor

@salexo salexo commented Jan 31, 2025

Description

  • PVC created and mounted to workloads when requested via --storage flag
  • PVC and configmap deleted when parent workload is deleted via owner reference and delete propagation policy
  • HF_HOME env var set to use the PVC

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project. See contributing-guidelines.md
  • Existing workload examples run after my changes (if applicable)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@salexo salexo self-assigned this Jan 31, 2025
@salexo salexo requested a review from AVSuni as a code owner January 31, 2025 08:17
Copy link
Contributor

@AVSuni AVSuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! didn't try all workloads yet, but requesting changes now so you have something to work with.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
pkg/cli/apply/run.go Show resolved Hide resolved
pkg/cli/apply/run.go Outdated Show resolved Hide resolved
pkg/workloads/apply.go Outdated Show resolved Hide resolved
pkg/workloads/apply.go Show resolved Hide resolved
pkg/workloads/apply.go Outdated Show resolved Hide resolved
pkg/workloads/apply.go Outdated Show resolved Hide resolved
@AVSuni AVSuni enabled auto-merge (squash) February 4, 2025 11:47
@AVSuni AVSuni merged commit fd0cc4c into main Feb 4, 2025
2 checks passed
@AVSuni AVSuni deleted the workload-pvcs branch February 4, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants