Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes #93

Merged
merged 1 commit into from
Feb 5, 2025
Merged

small fixes #93

merged 1 commit into from
Feb 5, 2025

Conversation

AVSuni
Copy link
Contributor

@AVSuni AVSuni commented Feb 4, 2025

Description

Small changes, including

  • Setting security context in all templates to ensure, among other things, ownership of mount paths
  • Allow Ray to manage GPU devices (disable RAY_EXPERIMENTAL_NOSET_ROCR_VISIBLE_DEVICES which is set by VLLM)
  • Update READMEs

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project. See contributing-guidelines.md
  • Existing workload examples run to completion after my changes (if applicable)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@AVSuni AVSuni marked this pull request as draft February 4, 2025 19:19
@AVSuni AVSuni requested a review from salexo February 4, 2025 19:30
@AVSuni AVSuni marked this pull request as ready for review February 5, 2025 05:16
@AVSuni AVSuni enabled auto-merge (squash) February 5, 2025 05:16
Copy link
Contributor

@salexo salexo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to fix 👍

@AVSuni AVSuni merged commit 62bbdf8 into main Feb 5, 2025
2 checks passed
@AVSuni AVSuni deleted the small-fixes branch February 5, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants